From: Vinod Koul <vinod.koul@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: djbw@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ioatdma: make debug output more readable
Date: Thu, 7 Mar 2013 17:57:59 +0530 [thread overview]
Message-ID: <20130307122759.GI13370@intel.com> (raw)
In-Reply-To: <20130304175954.9792.19327.stgit@djiang5-linux2.ch.intel.com>
On Mon, Mar 04, 2013 at 10:59:54AM -0700, Dave Jiang wrote:
> Making OP field a hex instead of integer to make it more readable. Also add
> the dump out of the NEXT field.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Applied thanks
> ---
> drivers/dma/ioat/dma.h | 2 +-
> drivers/dma/ioat/dma_v3.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ioat/dma.h b/drivers/dma/ioat/dma.h
> index 53a4cbb..95ae7b3 100644
> --- a/drivers/dma/ioat/dma.h
> +++ b/drivers/dma/ioat/dma.h
> @@ -179,7 +179,7 @@ __dump_desc_dbg(struct ioat_chan_common *chan, struct ioat_dma_descriptor *hw,
> struct device *dev = to_dev(chan);
>
> dev_dbg(dev, "desc[%d]: (%#llx->%#llx) cookie: %d flags: %#x"
> - " ctl: %#x (op: %d int_en: %d compl: %d)\n", id,
> + " ctl: %#10.8x (op: %#x int_en: %d compl: %d)\n", id,
> (unsigned long long) tx->phys,
> (unsigned long long) hw->next, tx->cookie, tx->flags,
> hw->ctl, hw->ctl_f.op, hw->ctl_f.int_en, hw->ctl_f.compl_write);
> diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
> index 53ea4bd..ce6fcee 100644
> --- a/drivers/dma/ioat/dma_v3.c
> +++ b/drivers/dma/ioat/dma_v3.c
> @@ -605,7 +605,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, struct
> int i;
>
> dev_dbg(dev, "desc[%d]: (%#llx->%#llx) flags: %#x"
> - " sz: %#x ctl: %#x (op: %d int: %d compl: %d pq: '%s%s' src_cnt: %d)\n",
> + " sz: %#10.8x ctl: %#x (op: %#x int: %d compl: %d pq: '%s%s' src_cnt: %d)\n",
> desc_id(desc), (unsigned long long) desc->txd.phys,
> (unsigned long long) (pq_ex ? pq_ex->next : pq->next),
> desc->txd.flags, pq->size, pq->ctl, pq->ctl_f.op, pq->ctl_f.int_en,
> @@ -617,6 +617,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, struct
> (unsigned long long) pq_get_src(descs, i), pq->coef[i]);
> dev_dbg(dev, "\tP: %#llx\n", pq->p_addr);
> dev_dbg(dev, "\tQ: %#llx\n", pq->q_addr);
> + dev_dbg(dev, "\tNEXT: %#llx\n", pq->next);
> }
>
> static struct dma_async_tx_descriptor *
>
next prev parent reply other threads:[~2013-03-07 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 17:59 [PATCH] ioatdma: make debug output more readable Dave Jiang
2013-03-05 22:20 ` Dan Williams
2013-03-05 22:26 ` Dave Jiang
2013-03-07 12:27 ` Vinod Koul [this message]
2013-03-07 12:28 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307122759.GI13370@intel.com \
--to=vinod.koul@intel.com \
--cc=dave.jiang@intel.com \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox