public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Dan Williams <djbw@fb.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ioatdma: allow all channels to have irq coalescing support
Date: Thu, 7 Mar 2013 17:58:51 +0530	[thread overview]
Message-ID: <20130307122851.GK13370@intel.com> (raw)
In-Reply-To: <84A937D219C2B44EB8EA44831ACA1E49171E519C@PRN-MBX02-3.TheFacebook.com>

On Tue, Mar 05, 2013 at 10:30:01PM +0000, Dan Williams wrote:
> 
> 
> On 2/26/13 8:20 AM, "Dave Jiang" <dave.jiang@intel.com> wrote:
> 
> >Looks like only the RAID channels are allowed to have irq coalescing
> >support
> >in the existing code. Fixing that. The ioat3 cleanup code can handle
> >memcpy
> >ops anyways
> >
> >Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Applied thanks
> >---
> > drivers/dma/ioat/dma_v3.c |   12 +++---------
> > 1 file changed, 3 insertions(+), 9 deletions(-)
> >
> >diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
> >index 47588dc..368a184 100644
> >--- a/drivers/dma/ioat/dma_v3.c
> >+++ b/drivers/dma/ioat/dma_v3.c
> >@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct
> >ioatdma_device *device, int dca)
> > 	}
> > 
> > 
> >-	if (is_raid_device) {
> >-		dma->device_tx_status = ioat3_tx_status;
> >-		device->cleanup_fn = ioat3_cleanup_event;
> >-		device->timer_fn = ioat3_timer_event;
> >-	} else {
> >-		dma->device_tx_status = ioat_dma_tx_status;
> >-		device->cleanup_fn = ioat2_cleanup_event;
> >-		device->timer_fn = ioat2_timer_event;
> >-	}
> >+	dma->device_tx_status = ioat3_tx_status;
> >+	device->cleanup_fn = ioat3_cleanup_event;
> >+	device->timer_fn = ioat3_timer_event;
> > 
> > 	#ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
> > 	dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);
> 
> Acked-by: Dan Williams <djbw@fb.com>
> 

      reply	other threads:[~2013-03-07 12:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 16:20 [PATCH] ioatdma: allow all channels to have irq coalescing support Dave Jiang
2013-03-05 22:30 ` Dan Williams
2013-03-07 12:28   ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130307122851.GK13370@intel.com \
    --to=vinod.koul@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=djbw@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox