* [PATCH] ioatdma: allow all channels to have irq coalescing support
@ 2013-02-26 16:20 Dave Jiang
2013-03-05 22:30 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jiang @ 2013-02-26 16:20 UTC (permalink / raw)
To: djbw; +Cc: vinod.koul, linux-kernel
Looks like only the RAID channels are allowed to have irq coalescing support
in the existing code. Fixing that. The ioat3 cleanup code can handle memcpy
ops anyways
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/ioat/dma_v3.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
index 47588dc..368a184 100644
--- a/drivers/dma/ioat/dma_v3.c
+++ b/drivers/dma/ioat/dma_v3.c
@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct ioatdma_device *device, int dca)
}
- if (is_raid_device) {
- dma->device_tx_status = ioat3_tx_status;
- device->cleanup_fn = ioat3_cleanup_event;
- device->timer_fn = ioat3_timer_event;
- } else {
- dma->device_tx_status = ioat_dma_tx_status;
- device->cleanup_fn = ioat2_cleanup_event;
- device->timer_fn = ioat2_timer_event;
- }
+ dma->device_tx_status = ioat3_tx_status;
+ device->cleanup_fn = ioat3_cleanup_event;
+ device->timer_fn = ioat3_timer_event;
#ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ioatdma: allow all channels to have irq coalescing support
2013-02-26 16:20 [PATCH] ioatdma: allow all channels to have irq coalescing support Dave Jiang
@ 2013-03-05 22:30 ` Dan Williams
2013-03-07 12:28 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2013-03-05 22:30 UTC (permalink / raw)
To: Dave Jiang; +Cc: vinod.koul@intel.com, linux-kernel@vger.kernel.org
On 2/26/13 8:20 AM, "Dave Jiang" <dave.jiang@intel.com> wrote:
>Looks like only the RAID channels are allowed to have irq coalescing
>support
>in the existing code. Fixing that. The ioat3 cleanup code can handle
>memcpy
>ops anyways
>
>Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>---
> drivers/dma/ioat/dma_v3.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
>diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
>index 47588dc..368a184 100644
>--- a/drivers/dma/ioat/dma_v3.c
>+++ b/drivers/dma/ioat/dma_v3.c
>@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct
>ioatdma_device *device, int dca)
> }
>
>
>- if (is_raid_device) {
>- dma->device_tx_status = ioat3_tx_status;
>- device->cleanup_fn = ioat3_cleanup_event;
>- device->timer_fn = ioat3_timer_event;
>- } else {
>- dma->device_tx_status = ioat_dma_tx_status;
>- device->cleanup_fn = ioat2_cleanup_event;
>- device->timer_fn = ioat2_timer_event;
>- }
>+ dma->device_tx_status = ioat3_tx_status;
>+ device->cleanup_fn = ioat3_cleanup_event;
>+ device->timer_fn = ioat3_timer_event;
>
> #ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
> dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);
Acked-by: Dan Williams <djbw@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ioatdma: allow all channels to have irq coalescing support
2013-03-05 22:30 ` Dan Williams
@ 2013-03-07 12:28 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2013-03-07 12:28 UTC (permalink / raw)
To: Dan Williams; +Cc: Dave Jiang, linux-kernel@vger.kernel.org
On Tue, Mar 05, 2013 at 10:30:01PM +0000, Dan Williams wrote:
>
>
> On 2/26/13 8:20 AM, "Dave Jiang" <dave.jiang@intel.com> wrote:
>
> >Looks like only the RAID channels are allowed to have irq coalescing
> >support
> >in the existing code. Fixing that. The ioat3 cleanup code can handle
> >memcpy
> >ops anyways
> >
> >Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Applied thanks
> >---
> > drivers/dma/ioat/dma_v3.c | 12 +++---------
> > 1 file changed, 3 insertions(+), 9 deletions(-)
> >
> >diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
> >index 47588dc..368a184 100644
> >--- a/drivers/dma/ioat/dma_v3.c
> >+++ b/drivers/dma/ioat/dma_v3.c
> >@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct
> >ioatdma_device *device, int dca)
> > }
> >
> >
> >- if (is_raid_device) {
> >- dma->device_tx_status = ioat3_tx_status;
> >- device->cleanup_fn = ioat3_cleanup_event;
> >- device->timer_fn = ioat3_timer_event;
> >- } else {
> >- dma->device_tx_status = ioat_dma_tx_status;
> >- device->cleanup_fn = ioat2_cleanup_event;
> >- device->timer_fn = ioat2_timer_event;
> >- }
> >+ dma->device_tx_status = ioat3_tx_status;
> >+ device->cleanup_fn = ioat3_cleanup_event;
> >+ device->timer_fn = ioat3_timer_event;
> >
> > #ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
> > dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);
>
> Acked-by: Dan Williams <djbw@fb.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-07 12:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 16:20 [PATCH] ioatdma: allow all channels to have irq coalescing support Dave Jiang
2013-03-05 22:30 ` Dan Williams
2013-03-07 12:28 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox