* virtual irq isssue - regmap_irq
@ 2013-03-07 6:57 Ashish Jangam
2013-03-07 7:13 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Ashish Jangam @ 2013-03-07 6:57 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel, David Dajun Chen
Hi,
In regmap_irq if irq_base is unknown then regmap creates virq starting from 0
and it seems that in kernel 3.8 virq 0 usage is not permitted, since during irq
registration kernel throws a message "error: irq_desc already associated".
I'm not sure if this requires fix in regmap_irq or kernel, can you please
comment on this?
Thanks,
Ashish
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: virtual irq isssue - regmap_irq
2013-03-07 6:57 virtual irq isssue - regmap_irq Ashish Jangam
@ 2013-03-07 7:13 ` Mark Brown
2013-03-07 11:52 ` Ashish Jangam
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2013-03-07 7:13 UTC (permalink / raw)
To: Ashish Jangam; +Cc: linux-kernel, David Dajun Chen
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Thu, Mar 07, 2013 at 12:27:52PM +0530, Ashish Jangam wrote:
> In regmap_irq if irq_base is unknown then regmap creates virq starting from 0
> and it seems that in kernel 3.8 virq 0 usage is not permitted, since during irq
> registration kernel throws a message "error: irq_desc already associated".
> I'm not sure if this requires fix in regmap_irq or kernel, can you please
> comment on this?
This is a bug in your platform which will affect anything using a linear
domain. The platform isn't setting up its interrupts correctly so that
the core knows that those interrupts are reserved, ideally the platform
would just use domains for everything but at least irq_alloc_decs()
needs to know what is going on.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: virtual irq isssue - regmap_irq
2013-03-07 7:13 ` Mark Brown
@ 2013-03-07 11:52 ` Ashish Jangam
2013-03-07 14:22 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Ashish Jangam @ 2013-03-07 11:52 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel, David Dajun Chen
On Thu, 2013-03-07 at 15:13 +0800, Mark Brown wrote:
> On Thu, Mar 07, 2013 at 12:27:52PM +0530, Ashish Jangam wrote:
>
> > In regmap_irq if irq_base is unknown then regmap creates virq starting from 0
> > and it seems that in kernel 3.8 virq 0 usage is not permitted, since during irq
> > registration kernel throws a message "error: irq_desc already associated".
>
> > I'm not sure if this requires fix in regmap_irq or kernel, can you please
> > comment on this?
>
> This is a bug in your platform which will affect anything using a linear
> domain. The platform isn't setting up its interrupts correctly so that
> the core knows that those interrupts are reserved, ideally the platform
> would just use domains for everything but at least irq_alloc_decs()
> needs to know what is going on.
Thanks I got this, however in this case should regmap handle such
condition where domain is unknown?
By the way, I was testing on smdkv6410 where Dialog device is not a
component of the board.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: virtual irq isssue - regmap_irq
2013-03-07 11:52 ` Ashish Jangam
@ 2013-03-07 14:22 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-03-07 14:22 UTC (permalink / raw)
To: Ashish Jangam; +Cc: linux-kernel, David Dajun Chen
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Thu, Mar 07, 2013 at 05:22:35PM +0530, Ashish Jangam wrote:
> On Thu, 2013-03-07 at 15:13 +0800, Mark Brown wrote:
> > This is a bug in your platform which will affect anything using a linear
> > domain. The platform isn't setting up its interrupts correctly so that
> > the core knows that those interrupts are reserved, ideally the platform
> > would just use domains for everything but at least irq_alloc_decs()
> > needs to know what is going on.
> Thanks I got this, however in this case should regmap handle such
> condition where domain is unknown?
There is no "condition" or unknown domain for regmap to handle. regmap
asked its irqdomain for an interrupt number and was given one, it's got
no way of validating what it gets back and we don't want to end up
having workaround code all over the kernel for broken platforms.
> By the way, I was testing on smdkv6410 where Dialog device is not a
> component of the board.
The board is broken anyway; fix the board.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-07 14:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07 6:57 virtual irq isssue - regmap_irq Ashish Jangam
2013-03-07 7:13 ` Mark Brown
2013-03-07 11:52 ` Ashish Jangam
2013-03-07 14:22 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox