From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: oskar.andero@sonymobile.com, linux-kernel@vger.kernel.org,
davem@davemloft.net, anil.s.keshavamurthy@intel.com,
radovan.lekanovic@sonymobile.com,
=?utf-8?B?77+9IDxiam9ybi5kYXZpZHNzb25Ac29ueW1vYmlsZS5jb20+?=@thinktux.in.ibm.com
Subject: Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols
Date: Fri, 8 Mar 2013 11:33:41 +0530 [thread overview]
Message-ID: <20130308060341.GB4029@in.ibm.com> (raw)
In-Reply-To: <513967BD.9010602@hitachi.com>
On Fri, Mar 08, 2013 at 01:23:25PM +0900, Masami Hiramatsu wrote:
> (2013/03/07 19:44), oskar.andero@sonymobile.com wrote:
> > From: Bjorn Davidsson <bjorn.davidsson@sonymobile.com>
> >
> > The kprobes blacklist contains x86-specific symbols.
> > Looking for these in kallsyms takes unnecessary time
> > during startup on non-X86 platform.
> > Added #ifdef CONFIG_X86 around them.
>
> Right. however, it might be better break that into
> common and arch-specific lists, because there may be
> other arch-specific non-probe-able functions on each
> architecture...
Agreed. CONFIG_<arch> in kernel/* is not the right thing to do IMO.
You are moving the blacklist initialization to later in the next patch,
so how much overhead will it then be?
Ananth
next prev parent reply other threads:[~2013-03-08 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 10:44 [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols oskar.andero
2013-03-08 4:23 ` Masami Hiramatsu
2013-03-08 6:03 ` Ananth N Mavinakayanahalli [this message]
2013-03-08 13:17 ` oskar.andero
2013-03-08 13:15 ` oskar.andero
2013-03-09 1:23 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308060341.GB4029@in.ibm.com \
--to=ananth@in.ibm.com \
--cc==?utf-8?B?77+9IDxiam9ybi5kYXZpZHNzb25Ac29ueW1vYmlsZS5jb20+?=@thinktux.in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=oskar.andero@sonymobile.com \
--cc=radovan.lekanovic@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox