The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Davide Ciminaghi <ciminaghi@gnudd.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, rubini@gnudd.com, sameo@linux.intel.com,
	giancarlo.asnaghi@st.com, mturquette@linaro.org,
	linus.walleij@linaro.org, rob.herring@calxeda.com,
	broonie@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86, pci sta2x11-fixup: add function to access sta2x11 instance id
Date: Fri, 8 Mar 2013 16:13:34 +0000	[thread overview]
Message-ID: <201303081613.34371.arnd@arndb.de> (raw)
In-Reply-To: <1362756691-14736-3-git-send-email-ciminaghi@gnudd.com>

On Friday 08 March 2013, Davide Ciminaghi wrote:
> 
> The sta2x11 instance id will be included in clock names to make them
> unique in case of multiple sta2x11's living on the same machine.
> 
> Signed-off-by: Davide Ciminaghi <ciminaghi@gnudd.com>

I might be missing something, but this seems counterintuitive. Shouldn't
the clock names really be constant and independent of the instance?

The instance should be identified already by the dev_name, right?

	Arnd

  reply	other threads:[~2013-03-08 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 15:31 [PATCH 0/3] sta2x11 common clock framework implementation Davide Ciminaghi
2013-03-08 15:31 ` [PATCH 1/3] x86, pci sta2x11-fixup: add clk related field to struct sta2x11_instance Davide Ciminaghi
2013-03-08 15:31 ` [PATCH 2/3] x86, pci sta2x11-fixup: add function to access sta2x11 instance id Davide Ciminaghi
2013-03-08 16:13   ` Arnd Bergmann [this message]
2013-03-12  0:51     ` Davide Ciminaghi
2013-03-08 15:31 ` [PATCH 3/3] drivers/clk: sta2x11 common clock framework implementation Davide Ciminaghi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303081613.34371.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ciminaghi@gnudd.com \
    --cc=giancarlo.asnaghi@st.com \
    --cc=hpa@zytor.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mturquette@linaro.org \
    --cc=rob.herring@calxeda.com \
    --cc=rubini@gnudd.com \
    --cc=sameo@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox