Re: [PATCH v2 00/26] x86, irq: support ioapic device hotplug

H. Peter Anvin
2013-02-12T06:10:47Z

On 02/11/2013 01:34 AM, Ingo Molnar wrote:
>
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
>> Hi,
>>
>> Current x86 code does not support iapic hotplug yet.
>
> Please give a better high-level description: outline how an
> IO-APIC will be hotplugged physically and what changes the
> user will experience.
>
> That needs at least 2 paragraphs, not one cursory sentence. Then
> should come technical descriptions - but even those need
> improvements, please first explain the current status quo, then
> explain how that is inadequate for IO-APIC hot-plugging, *then*
> only explain what you are doing in the patch ...
>

A few more notes:

Please explain what you mean with pre-reserve IRQ blocks, and in
particular, how do you know what to reserve and for what?

Second, some of the things in this patchset seems to overlap with what
we would need to support MSI (as opposed to MSI-X), and you have several
patches related to MSI vs MSI-X. Are you also supporting multivector
MSI (I believe the answer is no) or could some of this work make
multivector MSI practical (possible)?

-hpa