Re: [PATCH v2 00/26] x86, irq: support ioapic device hotplug

Ingo Molnar
2013-02-11T09:34:24Z

* Yinghai Lu <yinghai@kernel.org> wrote:

> Hi,
>
> Current x86 code does not support iapic hotplug yet.

Please give a better high-level description: outline how an
IO-APIC will be hotplugged physically and what changes the
user will experience.

That needs at least 2 paragraphs, not one cursory sentence. Then
should come technical descriptions - but even those need
improvements, please first explain the current status quo, then
explain how that is inadequate for IO-APIC hot-plugging, *then*
only explain what you are doing in the patch ...

Thanks,

Ingo