Re: [PATCH v2 10/26] x86, irq: Convert irq_2_pin list to generic list

Konrad Rzeszutek Wilk
2013-03-08T20:14:18Z

On Fri, Mar 08, 2013 at 12:00:43PM -0800, Yinghai Lu wrote:
> On Fri, Mar 8, 2013 at 11:50 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> > On Fri, Feb 08, 2013 at 11:28:07AM -0800, Yinghai Lu wrote:
> >> Now irq_2_pin list is own grown list.
> >
> > I think you meant to say 'has its own list'. Not sure how
> > its growing?
> >
> >> We can use generic list to replace it so we could generic helper
> >> functions to operate it.
> >
> > You need to put the verb a bit earlier. Perhaps:
> >
> > ".. generic list to replace so that we can operate using
> > generic helper functions."
>
> missed use before generic helper.

That would work as well.

>
> >
> >>
> >> Also make free_irq_cfg() free irq_2_pin list to support coming ioapic
> >> hotplug.
> >
> > If you have them ready - could you say the titles of the patches here?
>
> list them all ?

No that would not work. Perhaps the first one that introduces the code
that uses irq_2_pin ?