From: Joerg Roedel <joro@8bytes.org>
To: Nikola Pajkovsky <npajkovs@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amd_iommu_init: remove __init from amd_iommu_erratum_746_workaround
Date: Sat, 9 Mar 2013 19:03:15 +0100 [thread overview]
Message-ID: <20130309180314.GB4876@8bytes.org> (raw)
In-Reply-To: <a6e63dc6f1bdc2d20f3d7d07a5d878e9c1b01d85.1361891160.git.npajkovs@redhat.com>
On Tue, Feb 26, 2013 at 04:12:05PM +0100, Nikola Pajkovsky wrote:
> commit 318fe78 ("IOMMU, AMD Family15h Model10-1Fh erratum 746 Workaround")
> added amd_iommu_erratum_746_workaround and it's marked as __init, which is wrong
>
> WARNING: drivers/iommu/built-in.o(.text+0x639c): Section mismatch in reference from the function iommu_init_pci() to the function .init.text:amd_iommu_erratum_746_workaround()
> The function iommu_init_pci() references
> the function __init amd_iommu_erratum_746_workaround().
> This is often because iommu_init_pci lacks a __init
> annotation or the annotation of amd_iommu_erratum_746_workaround is wrong.
>
> Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
Applied to iommu/fixes, thanks.
prev parent reply other threads:[~2013-03-09 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 15:12 [PATCH] amd_iommu_init: remove __init from amd_iommu_erratum_746_workaround Nikola Pajkovsky
2013-03-09 18:03 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309180314.GB4876@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npajkovs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox