From: Oleg Nesterov <oleg@redhat.com>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: lucas.de.marchi@gmail.com, David Howells <dhowells@redhat.com>,
James Morris <james.l.morris@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] Split remaining calls to call_usermodehelper_fns()
Date: Sat, 9 Mar 2013 21:42:42 +0100 [thread overview]
Message-ID: <20130309204242.GA17303@redhat.com> (raw)
In-Reply-To: <1362723313-839-7-git-send-email-lucas.demarchi@profusion.mobi>
On 03/08, Lucas De Marchi wrote:
>
> @@ -571,9 +572,17 @@ void do_coredump(siginfo_t *siginfo)
> goto fail_dropcount;
> }
>
> - retval = call_usermodehelper_fns(helper_argv[0], helper_argv,
> - NULL, UMH_WAIT_EXEC, umh_pipe_setup,
> - NULL, &cprm);
> + sub_info = call_usermodehelper_setup(helper_argv[0],
> + helper_argv, NULL, GFP_KERNEL,
> + umh_pipe_setup, NULL, &cprm);
> + if (!sub_info) {
> + printk(KERN_WARNING "%s failed to allocate memory\n",
> + __func__);
Why?
> + argv_free(helper_argv);
> + goto fail_dropcount;
> + }
> +
> + retval = call_usermodehelper_exec(sub_info, UMH_WAIT_EXEC);
I do not really like another argv_free() here... How about
retval = -ENOMEM;
info = call_usermodehelper_setup(...);
if (info)
retval = call_usermodehelper_fns(...);
argv_free();
?
Oleg.
next prev parent reply other threads:[~2013-03-09 20:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 6:15 [PATCH v2 0/7] kmod/usermodehelper changes Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 1/7] kernel/sys.c: Use the simpler call_usermodehelper() Lucas De Marchi
2013-03-09 20:17 ` Oleg Nesterov
2013-03-08 6:15 ` [PATCH v2 2/7] usermodehelper: Export _exec() and _setup() functions Lucas De Marchi
2013-03-09 20:21 ` Oleg Nesterov
2013-03-08 6:15 ` [PATCH v2 3/7] kmod: split call to call_usermodehelper_fns() Lucas De Marchi
2013-03-09 20:23 ` Oleg Nesterov
2013-03-09 23:54 ` Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 4/7] KEYS: " Lucas De Marchi
2013-03-09 20:25 ` Oleg Nesterov
2013-03-09 23:55 ` Lucas De Marchi
2013-03-25 12:55 ` David Howells
2013-03-25 13:11 ` Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 5/7] coredump: remove trailling whitespaces Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 6/7] Split remaining calls to call_usermodehelper_fns() Lucas De Marchi
2013-03-09 20:42 ` Oleg Nesterov [this message]
2013-03-09 23:57 ` Lucas De Marchi
2013-03-08 6:15 ` [PATCH v2 7/7] kmod: remove call_usermodehelper_fns() Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309204242.GA17303@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox