* [PATCH] s390: replace kmalloc + memset with kzalloc
@ 2013-03-10 13:13 Stelian Nirlu
2013-03-10 14:14 ` Pekka Enberg
0 siblings, 1 reply; 4+ messages in thread
From: Stelian Nirlu @ 2013-03-10 13:13 UTC (permalink / raw)
To: schwidefsky
Cc: heiko.carstens, linux390, linux-s390, linux-kernel, Stelian Nirlu
Signed-off-by: Stelian Nirlu <steliannirlu@gmail.com>
---
arch/s390/net/bpf_jit_comp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
index 0972e91..e645528 100644
--- a/arch/s390/net/bpf_jit_comp.c
+++ b/arch/s390/net/bpf_jit_comp.c
@@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
if (!bpf_jit_enable)
return;
- addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
+ addrs = kzalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
if (addrs == NULL)
return;
- memset(addrs, 0, fp->len * sizeof(*addrs));
memset(&jit, 0, sizeof(cjit));
memset(&cjit, 0, sizeof(cjit));
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] s390: replace kmalloc + memset with kzalloc
2013-03-10 13:13 [PATCH] s390: replace kmalloc + memset with kzalloc Stelian Nirlu
@ 2013-03-10 14:14 ` Pekka Enberg
2013-03-11 11:33 ` Heiko Carstens
0 siblings, 1 reply; 4+ messages in thread
From: Pekka Enberg @ 2013-03-10 14:14 UTC (permalink / raw)
To: Stelian Nirlu
Cc: schwidefsky, heiko.carstens, linux390, linux-s390, linux-kernel
On Sun, Mar 10, 2013 at 3:13 PM, Stelian Nirlu <steliannirlu@gmail.com> wrote:
> Signed-off-by: Stelian Nirlu <steliannirlu@gmail.com>
> ---
> arch/s390/net/bpf_jit_comp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> index 0972e91..e645528 100644
> --- a/arch/s390/net/bpf_jit_comp.c
> +++ b/arch/s390/net/bpf_jit_comp.c
> @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
>
> if (!bpf_jit_enable)
> return;
> - addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> + addrs = kzalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
kcalloc() might be more appropriate here to protect against integer
overflow if "fp->len" is too large.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] s390: replace kmalloc + memset with kzalloc
2013-03-10 14:14 ` Pekka Enberg
@ 2013-03-11 11:33 ` Heiko Carstens
[not found] ` <CACtXKtSzv666_FCHpVm0EkyW=c32kQA9o9-zDqVtJcFYk9mHqQ@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Carstens @ 2013-03-11 11:33 UTC (permalink / raw)
To: Pekka Enberg
Cc: Stelian Nirlu, schwidefsky, linux390, linux-s390, linux-kernel
On Sun, Mar 10, 2013 at 04:14:00PM +0200, Pekka Enberg wrote:
> On Sun, Mar 10, 2013 at 3:13 PM, Stelian Nirlu <steliannirlu@gmail.com> wrote:
> > Signed-off-by: Stelian Nirlu <steliannirlu@gmail.com>
> > ---
> > arch/s390/net/bpf_jit_comp.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> > index 0972e91..e645528 100644
> > --- a/arch/s390/net/bpf_jit_comp.c
> > +++ b/arch/s390/net/bpf_jit_comp.c
> > @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
> >
> > if (!bpf_jit_enable)
> > return;
> > - addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> > + addrs = kzalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
>
> kcalloc() might be more appropriate here to protect against integer
> overflow if "fp->len" is too large.
Stelian, care to send an updated patch which uses kcalloc()
instead of kzalloc()?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-11 16:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 13:13 [PATCH] s390: replace kmalloc + memset with kzalloc Stelian Nirlu
2013-03-10 14:14 ` Pekka Enberg
2013-03-11 11:33 ` Heiko Carstens
[not found] ` <CACtXKtSzv666_FCHpVm0EkyW=c32kQA9o9-zDqVtJcFYk9mHqQ@mail.gmail.com>
2013-03-11 16:26 ` Stelian Nirlu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox