Re: [GIT PULL] EDAC fixes for 3.8

Mauro Carvalho Chehab
2013-03-12T10:55:27Z

Em Tue, 12 Mar 2013 09:58:55 +0100
Borislav Petkov <bp@alien8.de> escreveu:

> On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote:
> > @@ -740,7 +740,6 @@ struct mem_ctl_info {
> > u32 fake_inject_ue;
> > u16 fake_inject_count;
> > #endif
> > - __u8 csbased : 1, /* csrow-based memory controller */
> > __resv : 7;
>
> I don't know how you tested this one, but it doesn't even build. I fixed
> it up though, while applying.

Funny enough, it compiled on one machine. I noticed this issue when
compiling the Fedora kernel and just dropped the __resv field, that it is
not used anywhere. So, on the Fedora 18 Kernel I pointed, I just dropped both
lines.

Regards,
Mauro

>
> In file included from arch/x86/kernel/nmi.c:23:0:
> include/linux/edac.h:743:7: error: expected specifier-qualifier-list before ‘__resv’
> In file included from arch/x86/kernel/traps.c:44:0:
> include/linux/edac.h:743:7: error: expected specifier-qualifier-list before ‘__resv’
> make[2]: *** [arch/x86/kernel/nmi.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[2]: *** [arch/x86/kernel/traps.o] Error 1
> make[1]: *** [arch/x86/kernel] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [arch/x86] Error 2
> make: *** Waiting for unfinished jobs....
> In file included from drivers/edac/edac_stub.c:16:0:
> include/linux/edac.h:743:7: error: expected specifier-qualifier-list before ‘__resv’
> make[2]: *** [drivers/edac/edac_stub.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> In file included from drivers/edac/amd64_edac.h:72:0,
> from drivers/edac/amd64_edac.c:1:
> include/linux/edac.h:743:7: error: expected specifier-qualifier-list before ‘__resv’
> In file included from drivers/edac/amd64_edac.h:72:0,
> from drivers/edac/amd64_edac_inj.c:1:
> include/linux/edac.h:743:7: error: expected specifier-qualifier-list before ‘__resv’
> make[2]: *** [drivers/edac/amd64_edac_inj.o] Error 1
> make[2]: *** [drivers/edac/amd64_edac.o] Error 1
> make[1]: *** [drivers/edac] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2
>

--

Cheers,
Mauro