From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
Qing Xu <qingx@marvell.com>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 4/9] mfd: max8925: fix trivial build warning for non-dt
Date: Mon, 11 Mar 2013 16:31:06 +0000 [thread overview]
Message-ID: <201303111631.06866.arnd@arndb.de> (raw)
In-Reply-To: <1360880818-4071454-5-git-send-email-arnd@arndb.de>
On Thursday 14 February 2013, Arnd Bergmann wrote:
> Patch fe527ea5a "mfd: max8925: Support dt for backlight"
> added a new function for DT probing but introduced a
> build warning for the case where CONFIG_OF is disabled:
>
> drivers/video/backlight/max8925_bl.c: In function 'max8925_backlight_probe':
> drivers/video/backlight/max8925_bl.c:177:3: warning: statement with no effect [-Wunused-value]
>
> A much nicer fix is to use the IS_ENABLED keyword to
> have the same effect of dropping the device tree specific
> function when it's not needed.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Qing Xu <qingx@marvell.com>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
Hmm, it seems I already had this patch for the issue, but for some reason it
didn't apply for some time and when I looked at the problem again now, I found
more issues, and I'd suggest reverting commit fe527ea5a completely. There are
similar problems in the max8925_power patch.
Arnd
next prev parent reply other threads:[~2013-03-11 16:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 22:26 [PATCH 0/9] linux-next ARM defconfig fixes Arnd Bergmann
2013-02-14 22:26 ` [PATCH 1/9] ARM: sa1100/assabet: include platform_device.h directly Arnd Bergmann
2013-02-14 22:26 ` [PATCH 2/9] fb/exynos: include platform_device.h Arnd Bergmann
2013-02-14 22:26 ` [PATCH 3/9] clk: sunxi: remove stale Makefile entry Arnd Bergmann
2013-02-15 4:54 ` Mike Turquette
2013-02-15 12:08 ` Arnd Bergmann
2013-02-14 22:26 ` [PATCH 4/9] mfd: max8925: fix trivial build warning for non-dt Arnd Bergmann
2013-02-15 1:25 ` Haojian Zhuang
2013-02-15 3:32 ` Qing Xu
2013-03-11 16:31 ` Arnd Bergmann [this message]
2013-02-14 22:26 ` [PATCH 5/9] ARM: shmobile: mark mackerel sh_mmcif_device __maybe_unused Arnd Bergmann
2013-02-14 23:24 ` Simon Horman
2013-02-15 12:55 ` Arnd Bergmann
2013-02-15 13:15 ` Simon Horman
2013-02-14 22:26 ` [PATCH 6/9] drm/pci: move drm_pcie_get_speed_cap_mask inside #ifdef CONFIG_PCI Arnd Bergmann
2013-02-14 22:41 ` Fabio Estevam
2013-02-14 22:52 ` Arnd Bergmann
2013-02-14 22:26 ` [PATCH 7/9] ARM defconfigs: add missing inclusions of linux/platform_device.h Arnd Bergmann
2013-02-14 23:05 ` Greg Kroah-Hartman
2013-02-15 14:16 ` fb: mmp: include linux/platform_device.h Arnd Bergmann
2013-02-17 15:45 ` Haojian Zhuang
2013-02-14 22:26 ` [PATCH 8/9] [media] s5p-fimc: fix s5pv210 build Arnd Bergmann
2013-02-14 22:26 ` [PATCH 9/9] thermal: rcar: remove __devinitconst Arnd Bergmann
2013-02-19 15:48 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303111631.06866.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qingx@marvell.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox