Re: torrent hash failures since 3.9.0-rc1

[Zheng Liu <gnehzuil.liu@gmail.com>]

On Tue, Mar 12, 2013 at 07:48:10AM +0100, Markus Trippelsdorf wrote:
> On 2013.03.12 at 14:44 +0800, Zheng Liu wrote:
> > On Tue, Mar 12, 2013 at 07:16:24AM +0100, Markus Trippelsdorf wrote:
> > > On 2013.03.11 at 23:30 -0400, Theodore Ts'o wrote:
> > > > On Tue, Mar 12, 2013 at 11:00:58AM +0800, Zheng Liu wrote:
> > > > > 
> > > > > Thanks for reporting this problem.  My deepest apologies.
> > > > > 
> > > > > As Ted suggested, could you please try to use ext4 git tree?  I want to
> > > > > make sure whether this bug has been fixed by my lastest patch series or
> > > > > not.
> > > > 
> > > > It's definitely worth a try to compile the master branch of the ext4
> > > > tree and see if it reproduces or not.
> > > 
> > > I cannot reproduce the issue on top of "ext4.git dev", so fortunately
> > > the problem seems to be already fixed there.
> > > Thanks.
> > 
> > Great!  Thanks for the confirmation.
> > 
> > > 
> > > Do you guys have a hunch which commit is the actual fix? 
> > > (Maybe I will "bisect" it later today.)
> > 
> > I think maybe this two commits can fix it, but I am not sure which one
> > is the actual fix (I guess it is the former one, ;-) ).  Please try it
> > if you could bisect it.  Thanks in advance.
> > 
> >  * 079d7667af20876a59a1d9b0d4d1e15dcf17fa34
> >    ext4: fix wrong the number of the allocated blocks in
> > ext4_split_extent()
> 
> Your guess was right. The commit above is the actual fix.

Thank you so much for verifing it. :-)

Ted, I am wandering if we need to Cc this patch to stable kernel.  We
don't receive any report to complaint it, though, but it is worth
backporting it I think.

Regards,
                                                - Zheng