From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Julien Tinnes <jln@google.com>,
marcheu@chromium.org
Subject: Re: [PATCH v3] drm/i915: bounds check execbuffer relocation count
Date: Tue, 12 Mar 2013 09:07:46 +0000 [thread overview]
Message-ID: <20130312090746.GD31324@cantiga.alporthouse.com> (raw)
In-Reply-To: <20130312003145.GA28993@www.outflux.net>
On Mon, Mar 11, 2013 at 05:31:45PM -0700, Kees Cook wrote:
> It is possible to wrap the counter used to allocate the buffer for
> relocation copies. This could lead to heap writing overflows.
>
> CVE-2013-0913
>
> v3: collapse test, improve comment
> v2: move check into validate_exec_list
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Reported-by: Pinkie Pie
> Cc: stable@vger.kernel.org
Looks good to me. The only bikeshed that remains is whether we should
just collapse the two variables into one, but the current 'max - count'
is more idiomatic and so preferrable.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-03-12 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 0:31 [PATCH v3] drm/i915: bounds check execbuffer relocation count Kees Cook
2013-03-12 9:07 ` Chris Wilson [this message]
2013-03-13 20:28 ` Daniel Vetter
2013-03-14 16:57 ` Daniel Vetter
2013-03-14 19:32 ` Kees Cook
2013-03-15 12:32 ` [Intel-gfx] " Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312090746.GD31324@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jln@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcheu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox