From: Paul Mundt <lethal@linux-sh.org>
To: Alex Courbot <acourbot@nvidia.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@arm.linux.org.uk>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Mike Frysinger <vapier@gentoo.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ralf Baechle <ralf@linux-mips.org>,
Jonas Bonn <jonas@southpole.se>, Josh Boyer <jwboyer@gmail.com>,
Matt Porter <mporter@kernel.crashing.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Kumar Gala <galak@kernel.crashing.org>,
Vitaly Bordug <vitb@kernel.crashing.org>,
Marcelo Tosatti <marcelo@kvack.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 09/17] sh: replace CONFIG_GENERIC_GPIO by CONFIG_GPIOLIB
Date: Tue, 12 Mar 2013 19:52:30 +0900 [thread overview]
Message-ID: <20130312105228.GA23752@linux-sh.org> (raw)
In-Reply-To: <513F06DF.3040105@nvidia.com>
On Tue, Mar 12, 2013 at 07:43:43PM +0900, Alex Courbot wrote:
> On 03/12/2013 07:35 PM, Paul Mundt wrote:
> >On Tue, Mar 12, 2013 at 07:12:22PM +0900, Alexandre Courbot wrote:
> >>SH GPIO drivers all use gpiolib and CONFIG_GENERIC_GPIO is only selected
> >>through CONFIG_GPIOLIB, yet some compilation units depended on
> >>CONFIG_GENERIC_GPIO. Make them depend on CONFIG_GPIOLIB instead since it
> >>is more accurate and prepares us for the future removal of
> >>CONFIG_GENERIC_GPIO.
> >>
> >>Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> >
> >Note that the bulk of the GENERIC_GPIO use for SH has shifted to
> >drivers/pinctrl/sh-pfc/. If GPIOLIB is forced then a good chunk of the
> >Kconfig/Makefile bits there ought to be refactored too.
>
> Yes, that is the case for many other drivers actually. This series
> just makes sure that GENERIC_GPIO is set through GPIOLIB *only*,
> thus making both options equivalent. If nobody shoots me for this, I
> will refactor individual drivers and ultimately remove GENERIC_GPIO
> completely.
>
Ok, just wanted to make sure you were aware of this. I don't have any
strong opinions on this one way or the other, the entire GPIO Kconfig
mess is too ugly for words, so any effort to clean that up is probably
worth the added bloat.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2013-03-12 10:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 10:12 [RFC 00/17] Remove GENERIC_GPIO from architecture code Alexandre Courbot
2013-03-12 10:12 ` [RFC 01/17] arm: remove unneeded select GENERIC_GPIO Alexandre Courbot
2013-03-12 10:12 ` [RFC 02/17] arm: remove redundant GENERIC_GPIO selection Alexandre Courbot
2013-03-12 10:12 ` [RFC 03/17] arm: plat-orion: use GPIO driver on CONFIG_GPIOLIB Alexandre Courbot
2013-03-12 10:12 ` [RFC 04/17] mips: remove redundant GENERIC_GPIO select Alexandre Courbot
2013-03-12 10:12 ` [RFC 05/17] mips: loongson: use GPIO driver on CONFIG_GPIOLIB Alexandre Courbot
2013-03-12 10:12 ` [RFC 06/17] mips: txx9: change GENERIC_GPIO to GPIOLIB Alexandre Courbot
2013-03-12 10:12 ` [RFC 07/17] unicore32: remove unneeded select GENERIC_GPIO Alexandre Courbot
2013-03-12 10:12 ` [RFC 08/17] powerpc: remove redundant GENERIC_GPIO selection Alexandre Courbot
2013-03-12 10:12 ` [RFC 09/17] sh: replace CONFIG_GENERIC_GPIO by CONFIG_GPIOLIB Alexandre Courbot
2013-03-12 10:35 ` Paul Mundt
2013-03-12 10:43 ` Alex Courbot
2013-03-12 10:52 ` Paul Mundt [this message]
2013-03-12 10:12 ` [RFC 10/17] xtensa: remove explicit selection of GENERIC_GPIO Alexandre Courbot
2013-03-12 10:12 ` [RFC 11/17] mips: alchemy: require gpiolib Alexandre Courbot
2013-03-12 10:12 ` [RFC 12/17] mips: pnx833x: remove requirement for GENERIC_GPIO Alexandre Courbot
2013-03-12 10:12 ` [RFC 13/17] avr32: default GENERIC_GPIO to false Alexandre Courbot
2013-03-12 10:12 ` [RFC 14/17] m68k: coldfire: use gpiolib Alexandre Courbot
2013-03-12 10:12 ` [RFC 15/17] avr32: default GENERIC_GPIO to false Alexandre Courbot
2013-03-12 12:55 ` Hans-Christian Egtvedt
2013-03-12 13:23 ` Alexandre Courbot
2013-03-12 10:12 ` [RFC 16/17] openrisc: " Alexandre Courbot
2013-03-13 5:53 ` Jonas Bonn
2013-03-12 10:12 ` [RFC 17/17] unicore32: " Alexandre Courbot
2013-03-12 11:18 ` Arnd Bergmann
[not found] ` <CAAVeFuLJ0VvdOkqyNaVCbFHE-x==OYFC_=HEF2YLqaK6mM+rBw@mail.gmail.com>
2013-03-12 12:10 ` Arnd Bergmann
2013-03-12 13:30 ` Alexandre Courbot
2013-03-12 13:57 ` Arnd Bergmann
2013-03-12 11:23 ` [RFC 00/17] Remove GENERIC_GPIO from architecture code Arnd Bergmann
2013-03-12 13:44 ` Alexandre Courbot
2013-03-13 5:12 ` Linus Walleij
2013-03-13 7:53 ` Grant Likely
2013-03-13 18:01 ` Linus Walleij
2013-03-14 14:08 ` Alexandre Courbot
2013-03-14 14:14 ` Linus Walleij
2013-03-14 14:23 ` Alexandre Courbot
2013-03-14 15:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312105228.GA23752@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=egtvedt@samfundet.no \
--cc=galak@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gxt@mprc.pku.edu.cn \
--cc=hskinnemoen@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=jwboyer@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marcelo@kvack.org \
--cc=mporter@kernel.crashing.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=vapier@gentoo.org \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox