linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, laijs@cn.fujitsu.com, fengguang.wu@intel.com,
	linux-kernel@vger.kernel.org, jmoyer@redhat.com
Subject: Re: [PATCH 2/4] writeback: remove unused bdi_pending_list
Date: Tue, 12 Mar 2013 13:02:00 +0100	[thread overview]
Message-ID: <20130312120200.GD13152@quack.suse.cz> (raw)
In-Reply-To: <1362692649-25570-3-git-send-email-tj@kernel.org>

On Thu 07-03-13 13:44:07, Tejun Heo wrote:
> There's no user left.  Remove it.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
  Looks good. You can add
Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/backing-dev.h | 1 -
>  mm/backing-dev.c            | 4 +---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 3504599..a5ef27f 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -130,7 +130,6 @@ void bdi_lock_two(struct bdi_writeback *wb1, struct bdi_writeback *wb2);
>  
>  extern spinlock_t bdi_lock;
>  extern struct list_head bdi_list;
> -extern struct list_head bdi_pending_list;
>  
>  static inline int wb_has_dirty_io(struct bdi_writeback *wb)
>  {
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index 41733c5..657569b 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -31,13 +31,11 @@ EXPORT_SYMBOL_GPL(noop_backing_dev_info);
>  static struct class *bdi_class;
>  
>  /*
> - * bdi_lock protects updates to bdi_list and bdi_pending_list, as well as
> - * reader side protection for bdi_pending_list. bdi_list has RCU reader side
> + * bdi_lock protects updates to bdi_list. bdi_list has RCU reader side
>   * locking.
>   */
>  DEFINE_SPINLOCK(bdi_lock);
>  LIST_HEAD(bdi_list);
> -LIST_HEAD(bdi_pending_list);
>  
>  void bdi_lock_two(struct bdi_writeback *wb1, struct bdi_writeback *wb2)
>  {
> -- 
> 1.8.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2013-03-12 12:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 21:44 [PATCHSET] writeback: convert writeback to unbound workqueue Tejun Heo
2013-03-07 21:44 ` [PATCH 1/4] implement current_is_workqueue_rescuer() Tejun Heo
2013-03-13  0:42   ` Tejun Heo
2013-03-07 21:44 ` [PATCH 2/4] writeback: remove unused bdi_pending_list Tejun Heo
2013-03-12 12:02   ` Jan Kara [this message]
2013-03-07 21:44 ` [PATCH 3/4] writeback: replace custom worker pool implementation with unbound workqueue Tejun Heo
2013-03-12 15:05   ` Jan Kara
2013-03-18 22:32     ` Jan Kara
2013-03-18 22:35       ` Tejun Heo
2013-03-19 15:46         ` Jan Kara
2013-03-19 17:28           ` Tejun Heo
2013-03-21  1:57             ` Dave Chinner
2013-03-21  5:07               ` Tejun Heo
2013-03-21 11:32                 ` Jan Kara
2013-03-21 13:08                   ` Christoph Hellwig
2013-03-21 18:37                     ` Tejun Heo
2013-03-07 21:44 ` [PATCH 4/4] writeback: expose the bdi_wq workqueue Tejun Heo
2013-03-12 15:06 ` [PATCHSET] writeback: convert writeback to unbound workqueue Jens Axboe
2013-03-12 17:10   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130312120200.GD13152@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=fengguang.wu@intel.com \
    --cc=jmoyer@redhat.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).