Re: Fix memory leak in cpufreq stats.

Colin Cross
2013-03-12T01:23:30Z

On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote:
>>
>> Fix memory leak in cpufreq stats.
>>
>> When system enter sleep, non-boot CPUs will be disable.
>> Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
>> the CPU going down. This will cause memory leak.
>> signed-off-by: xiaobing tu <xiaobing.tu@intel.com>
>> signed-off-by: guifang tang <guifang.tang@intel.com>
>
> I will push this patch for v3.7 in the -rc3 time frame if no one objects.
>
> Thanks,
> Rafael
>
>
>> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
>> index b40ee14..3998316 100644
>> --- a/drivers/cpufreq/cpufreq_stats.c
>> +++ b/drivers/cpufreq/cpufreq_stats.c
>> @@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
>> cpufreq_update_policy(cpu);
>> break;
>> case CPU_DOWN_PREPARE:
>> + case CPU_DOWN_PREPARE_FROZEN:
>> cpufreq_stats_free_sysfs(cpu);
>> break;
>> case CPU_DEAD:
>>
>> Br
>> XiaoBing Tu
>> PSI@System Integration Shanghai

This patch, commited as e37736777254ce1abc85493a5cacbefe5983b896 since
v3.7, should also have gone to stable. It should apply all the way
back to 3.0.