From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
swarren@nvidia.com
Subject: Re: [PATCH V2 RESEND 2/2] regmap: irq: do not write mask register if it is not supported
Date: Tue, 12 Mar 2013 19:35:59 +0000 [thread overview]
Message-ID: <20130312193558.GE19942@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1362673997-6762-1-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
On Thu, Mar 07, 2013 at 10:03:16PM +0530, Laxman Dewangan wrote:
> Ignore the mask register write if mask_base is not provided by
> regmap irq client. Also assume that all interrupts are enabled
> in this case.
> This is useful when device does not have explicit interrupt mask
> register but control the interrupt enabling/disabling by other
> mechanism like irq type/irq edge registers.
I would really expect that the operations that mask things would be
failing if we can't perform them, things are going to get upset if they
get interrupts they thought were masked.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-03-12 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 16:33 [PATCH V2 RESEND 2/2] regmap: irq: do not write mask register if it is not supported Laxman Dewangan
2013-03-07 16:33 ` [PATCH V2 RESEND 1/2] regmap: irq: Add support for interrupt type Laxman Dewangan
2013-03-12 19:55 ` Mark Brown
2013-03-16 14:46 ` Laxman Dewangan
2013-03-12 19:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312193558.GE19942@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox