* [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT"
@ 2013-03-12 20:35 Paul Bolle
2013-03-13 6:33 ` Sam Ravnborg
2013-03-19 20:16 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Paul Bolle @ 2013-03-12 20:35 UTC (permalink / raw)
To: David S. Miller; +Cc: sparclinux, linux-kernel
Commit 2d78d4beb64eb07d50665432867971c481192ebf ("[PATCH] bitops:
sparc64: use generic bitops") made the default of GENERIC_HWEIGHT depend
on !ULTRA_HAS_POPULATION_COUNT. But since there's no Kconfig symbol with
that name, this always evaluates to true. Delete this dependency.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested with "make ARCH=sparc menuconfig" (before and after this
patch).
1) There apparently is an (obscure) preprocessor macro
ULTRA_HAS_POPULATION_COUNT. But the check for it got removed in commit
ef7c4d4675d2a9206f913f26ca1a5cd41bff9d41 ("sparc: Use popc if possible
for hweight routines.").
arch/sparc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 289127d..7fcd4b4 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -197,7 +197,7 @@ config RWSEM_XCHGADD_ALGORITHM
config GENERIC_HWEIGHT
bool
- default y if !ULTRA_HAS_POPULATION_COUNT
+ default y
config GENERIC_CALIBRATE_DELAY
bool
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT"
2013-03-12 20:35 [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT" Paul Bolle
@ 2013-03-13 6:33 ` Sam Ravnborg
2013-03-19 20:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2013-03-13 6:33 UTC (permalink / raw)
To: Paul Bolle; +Cc: David S. Miller, sparclinux, linux-kernel
On Tue, Mar 12, 2013 at 09:35:19PM +0100, Paul Bolle wrote:
> Commit 2d78d4beb64eb07d50665432867971c481192ebf ("[PATCH] bitops:
> sparc64: use generic bitops") made the default of GENERIC_HWEIGHT depend
> on !ULTRA_HAS_POPULATION_COUNT. But since there's no Kconfig symbol with
> that name, this always evaluates to true. Delete this dependency.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT"
2013-03-12 20:35 [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT" Paul Bolle
2013-03-13 6:33 ` Sam Ravnborg
@ 2013-03-19 20:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-19 20:16 UTC (permalink / raw)
To: pebolle; +Cc: sparclinux, linux-kernel
From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 12 Mar 2013 21:35:19 +0100
> Commit 2d78d4beb64eb07d50665432867971c481192ebf ("[PATCH] bitops:
> sparc64: use generic bitops") made the default of GENERIC_HWEIGHT depend
> on !ULTRA_HAS_POPULATION_COUNT. But since there's no Kconfig symbol with
> that name, this always evaluates to true. Delete this dependency.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied, thanks Paul.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-19 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-12 20:35 [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT" Paul Bolle
2013-03-13 6:33 ` Sam Ravnborg
2013-03-19 20:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).