From: Samuel Ortiz <sameo@linux.intel.com>
To: Roger Quadros <rogerq@ti.com>
Cc: "Balbi, Felipe" <balbi@ti.com>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>
Subject: Re: mfd: omap-usb-host: bug fix for 3.9
Date: Wed, 13 Mar 2013 09:34:22 +0100 [thread overview]
Message-ID: <20130313083422.GA21994@zurbaran> (raw)
In-Reply-To: <512E120D.7000101@ti.com>
Hi Roger,
On Wed, Feb 27, 2013 at 04:02:53PM +0200, Roger Quadros wrote:
> Hi Samuel,
>
> One of my patch that I sent for 3.9 introduces a bug that fails to
> update the port mode hostconfig register. Because of that, the port modes will
> always be 0 (i.e. EHCI PHY mode) and other modes will not work. PHY mode will
> work, so beagle/panda have no issues.
>
> Since my hardware setup uses only PHY mode, I couldn't catch this problem earlier.
>
> Below is the fix.
>
> From 82466757a212bd8b54d806c9d56b1acccbd4d464 Mon Sep 17 00:00:00 2001
> From: Roger Quadros <rogerq@ti.com>
> Date: Wed, 27 Feb 2013 15:19:24 +0200
> Subject: [PATCH] mfd: omap-usb-host: Actually update hostconfig
>
> The helper functions omap_usbhs_rev1_hostconfig()
> and omap_usbhs_rev2_hostconfig() don't write into
> the hostconfig register. Make sure that we write
> the return value into the hostconfig register.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-host.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Patch applied now, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-03-13 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 14:02 mfd: omap-usb-host: bug fix for 3.9 Roger Quadros
2013-03-06 9:33 ` Roger Quadros
2013-03-13 8:34 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313083422.GA21994@zurbaran \
--to=sameo@linux.intel.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).