From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jacob Garber <ajtgarber@gmail.com>
Cc: greg@kroah.com, devel@driverdev.osuosl.org,
fmhess@users.sourceforge.net, abbotti@mev.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fixed camel case style issue in usbdux.c
Date: Wed, 13 Mar 2013 23:37:18 +0300 [thread overview]
Message-ID: <20130313203718.GG9138@mwanda> (raw)
In-Reply-To: <1363191560-4410-1-git-send-email-ajtgarber@gmail.com>
On Wed, Mar 13, 2013 at 12:19:20PM -0400, Jacob Garber wrote:
> This is a patch to usbdux.c that fixes the camel case warnings found
> by the checkpatch.pl tool
>
> Signed-off-by: Jacob Garber <ajtgarber@gmail.com>
> ---
> -static int usbduxsub_submit_InURBs(struct usbduxsub *usbduxsub)
> +static int usbduxsub_submit_inurbs(struct usbduxsub *usbduxsub)
> {
> - int i, errFlag;
> + int i, err_flag;
>
This is really just a regular error code, not a flag. But that was
there in the original so no worries.
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2013-03-13 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 16:19 [PATCH] Staging: comedi: Fixed camel case style issue in usbdux.c Jacob Garber
2013-03-13 20:37 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313203718.GG9138@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=ajtgarber@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox