From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: s390: net: Replaced kmalloc and memset with kzalloc
Date: Thu, 14 Mar 2013 08:25:04 +0100 [thread overview]
Message-ID: <20130314072504.GC3480@osiris> (raw)
In-Reply-To: <1363201157-17545-1-git-send-email-gheorghiuandru@gmail.com>
On Wed, Mar 13, 2013 at 08:59:17PM +0200, Alexandru Gheorghiu wrote:
> Used kzalloc instead of kmalloc followed by memset with 0.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
> ---
> arch/s390/net/bpf_jit_comp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> index 0972e91..e645528 100644
> --- a/arch/s390/net/bpf_jit_comp.c
> +++ b/arch/s390/net/bpf_jit_comp.c
> @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
>
> if (!bpf_jit_enable)
> return;
> - addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> + addrs = kzalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> if (addrs == NULL)
> return;
> - memset(addrs, 0, fp->len * sizeof(*addrs));
We have already a different patch from Stelian Nirlu for the same stuff.
prev parent reply other threads:[~2013-03-14 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 18:59 [PATCH] arch: s390: net: Replaced kmalloc and memset with kzalloc Alexandru Gheorghiu
2013-03-14 7:25 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314072504.GC3480@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=gheorghiuandru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox