From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ccg: remove two outdated dependencies
Date: Thu, 14 Mar 2013 13:59:53 +0300 [thread overview]
Message-ID: <20130314105953.GJ9138@mwanda> (raw)
In-Reply-To: <1363256224.1335.46.camel@x61.thuisdomein>
On Thu, Mar 14, 2013 at 11:17:04AM +0100, Paul Bolle wrote:
> 1) This patch is rather hard to review. That is because the "depends on"
> line is rather hard to read. Perhaps the easiest way to review is to do
> git grep -n "\bUSB_FILE_STORAGE\(_TEST\)\?\b"
>
> before and after applying this patch. But that doesn't catch possible
> other, unwanted, changes. Maybe we need to split up the "depends on"
> line before removing these two negative entries.
Your patch is fine as is, but if you wanted to send a follow on
patch to break the depend mess into separate lines, that would also
be welcome. :)
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2013-03-14 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 10:17 [PATCH] staging: ccg: remove two outdated dependencies Paul Bolle
2013-03-14 10:59 ` Dan Carpenter [this message]
2013-03-14 11:09 ` Paul Bolle
2013-03-14 11:28 ` Dan Carpenter
2013-03-14 22:02 ` Greg Kroah-Hartman
2013-03-14 22:12 ` Paul Bolle
2013-03-14 22:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314105953.GJ9138@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox