From: Thierry Reding <thierry.reding@avionic-design.de>
To: Hiroshi Doyu <hdoyu@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-tegra@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME
Date: Thu, 14 Mar 2013 21:04:31 +0100 [thread overview]
Message-ID: <20130314200431.GA4252@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1363252089-4120-1-git-send-email-hdoyu@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On Thu, Mar 14, 2013 at 11:08:09AM +0200, Hiroshi Doyu wrote:
> Make this depend on CONFIG_PM. This protection is necessary to not
> cause any build errors with any combination of PM features especially
> when supporting a new SoC where each PM features are being enabled
> one-by-one during its depelopment.
>
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> Reported-by: Joseph Lo <josephl@nvidia.com>
> ---
> drivers/amba/tegra-ahb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c
> index 093c435..1f44e56 100644
> --- a/drivers/amba/tegra-ahb.c
> +++ b/drivers/amba/tegra-ahb.c
> @@ -158,7 +158,7 @@ int tegra_ahb_enable_smmu(struct device_node *dn)
> EXPORT_SYMBOL(tegra_ahb_enable_smmu);
> #endif
>
> -#ifdef CONFIG_PM_SLEEP
> +#ifdef CONFIG_PM
> static int tegra_ahb_suspend(struct device *dev)
> {
> int i;
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-14 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 9:08 [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME Hiroshi Doyu
2013-03-14 20:04 ` Thierry Reding [this message]
2013-03-15 5:23 ` Stephen Warren
2013-03-15 6:56 ` Hiroshi Doyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314200431.GA4252@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=hdoyu@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox