public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, davej@redhat.com,
	sasha.levin@oracle.com, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, caiqian@redhat.com,
	eric.dumazet@gmail.com, lizefan@huawei.com
Subject: [PATCH tip/core/urgent] Fix for hlist_entry_safe() regression
Date: Thu, 14 Mar 2013 13:53:07 -0700	[thread overview]
Message-ID: <20130314205307.GA27968@linux.vnet.ibm.com> (raw)

Hello, Ingo

This series contains a single commit that fixes a regression in
hlist_entry_safe().  This macro references its argument twice, which
can cause NULL-pointer errors.  This commit applies a gcc statement
expression, creating a temporary variable to avoid the double reference.
This has been posted to LKML at https://lkml.org/lkml/2013/3/9/75.

Kudos to CAI Qian, whose testing uncovered this, to Eric Dumazet, who
spotted root cause, and to Li Zefan, who tested this commit.

This commit is available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent

							Thanx, Paul

----------------------------------------------------------------
Paul E. McKenney (1):
      list: Fix double fetch of pointer in hlist_entry_safe()

 include/linux/list.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


             reply	other threads:[~2013-03-14 20:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14 20:53 Paul E. McKenney [this message]
2013-03-21 14:22 ` [GIT PULL tip/core/urgent] Fix for hlist_entry_safe() regression Paul E. McKenney
2013-03-21 14:42   ` Linus Torvalds
2013-03-21 15:05     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130314205307.GA27968@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=caiqian@redhat.com \
    --cc=davej@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@elte.hu \
    --cc=sasha.levin@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox