From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: Remove __attribute__ ((packed))
Date: Fri, 15 Mar 2013 21:22:51 +0000 [thread overview]
Message-ID: <20130315212251.GA28907@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130315165351.GA8988@opensource.wolfsonmicro.com>
On Fri, Mar 15, 2013 at 04:53:51PM +0000, Mark Brown wrote:
> On Fri, Mar 15, 2013 at 11:16:02AM +0000, Dimitris Papastamos wrote:
>
> > On my system there was no benefit of using it, it just happens
> > that the struct is aligned properly and needs no padding.
>
> OK, so which system was that and is it not possible that other systems
> will get something useful from this?
Well I guess it has to do with the gcc cross compiler version that
I've got and the actual data layout of the linking rbtree node.
The data seems to be aligned on a 4-byte boundary anyhow and
that should be ok for many systems.
Thanks,
Dimitris
prev parent reply other threads:[~2013-03-15 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 15:26 [PATCH] regmap: Remove __attribute__ ((packed)) Dimitris Papastamos
2013-03-15 1:36 ` Mark Brown
2013-03-15 11:16 ` Dimitris Papastamos
2013-03-15 16:53 ` Mark Brown
2013-03-15 21:22 ` Dimitris Papastamos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315212251.GA28907@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox