public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	LKML <linux-kernel@vger.kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] perf cgroup: Add __percpu annotation to perf_cgroup->info
Date: Mon, 18 Mar 2013 10:39:43 +0100	[thread overview]
Message-ID: <20130318093943.GA25045@gmail.com> (raw)
In-Reply-To: <1363583692-31631-1-git-send-email-namhyung@kernel.org>


* Namhyung Kim <namhyung@kernel.org> wrote:

> From: Namhyung Kim <namhyung.kim@lge.com>
> 
> It's a per-cpu data structure but missed the __percpu annotation.
> 
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  include/linux/perf_event.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 001a3b64fe61..16116aee9405 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -311,8 +311,8 @@ struct perf_cgroup_info {
>  };
>  
>  struct perf_cgroup {
> -	struct				cgroup_subsys_state css;
> -	struct				perf_cgroup_info *info;	/* timing info, one per cpu */
> +	struct cgroup_subsys_state 	css;
> +	struct perf_cgroup_info __percpu * info;
>  };
>  #endif

Would be nice to have this against tip:master - 'struct perf_cgroup' 
recently moved to kernel/events/, in the development tree.

Thanks,

	Ingo

  reply	other threads:[~2013-03-18  9:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18  5:14 [PATCH] perf cgroup: Add __percpu annotation to perf_cgroup->info Namhyung Kim
2013-03-18  9:39 ` Ingo Molnar [this message]
2013-03-18  9:56   ` [PATCH v2] " Namhyung Kim
2013-03-18 11:13     ` [tip:perf/core] perf/cgroup: " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130318093943.GA25045@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox