* [PATCH] perf cgroup: Add __percpu annotation to perf_cgroup->info
@ 2013-03-18 5:14 Namhyung Kim
2013-03-18 9:39 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Namhyung Kim @ 2013-03-18 5:14 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar
Cc: Arnaldo Carvalho de Melo, LKML, Namhyung Kim, Tejun Heo
From: Namhyung Kim <namhyung.kim@lge.com>
It's a per-cpu data structure but missed the __percpu annotation.
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
include/linux/perf_event.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 001a3b64fe61..16116aee9405 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -311,8 +311,8 @@ struct perf_cgroup_info {
};
struct perf_cgroup {
- struct cgroup_subsys_state css;
- struct perf_cgroup_info *info; /* timing info, one per cpu */
+ struct cgroup_subsys_state css;
+ struct perf_cgroup_info __percpu * info;
};
#endif
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf cgroup: Add __percpu annotation to perf_cgroup->info
2013-03-18 5:14 [PATCH] perf cgroup: Add __percpu annotation to perf_cgroup->info Namhyung Kim
@ 2013-03-18 9:39 ` Ingo Molnar
2013-03-18 9:56 ` [PATCH v2] " Namhyung Kim
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2013-03-18 9:39 UTC (permalink / raw)
To: Namhyung Kim
Cc: Peter Zijlstra, Arnaldo Carvalho de Melo, LKML, Namhyung Kim,
Tejun Heo
* Namhyung Kim <namhyung@kernel.org> wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> It's a per-cpu data structure but missed the __percpu annotation.
>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> include/linux/perf_event.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 001a3b64fe61..16116aee9405 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -311,8 +311,8 @@ struct perf_cgroup_info {
> };
>
> struct perf_cgroup {
> - struct cgroup_subsys_state css;
> - struct perf_cgroup_info *info; /* timing info, one per cpu */
> + struct cgroup_subsys_state css;
> + struct perf_cgroup_info __percpu * info;
> };
> #endif
Would be nice to have this against tip:master - 'struct perf_cgroup'
recently moved to kernel/events/, in the development tree.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] perf cgroup: Add __percpu annotation to perf_cgroup->info
2013-03-18 9:39 ` Ingo Molnar
@ 2013-03-18 9:56 ` Namhyung Kim
2013-03-18 11:13 ` [tip:perf/core] perf/cgroup: " tip-bot for Namhyung Kim
0 siblings, 1 reply; 4+ messages in thread
From: Namhyung Kim @ 2013-03-18 9:56 UTC (permalink / raw)
To: Ingo Molnar
Cc: Peter Zijlstra, Arnaldo Carvalho de Melo, LKML, Namhyung Kim,
Tejun Heo, Li Zefan
From: Namhyung Kim <namhyung.kim@lge.com>
It's a per-cpu data structure but missed the __percpu annotation.
Cc: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5976a2a6b4ce..efb75b3a69ad 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -245,7 +245,7 @@ struct perf_cgroup_info {
struct perf_cgroup {
struct cgroup_subsys_state css;
- struct perf_cgroup_info *info;
+ struct perf_cgroup_info __percpu *info;
};
/*
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* [tip:perf/core] perf/cgroup: Add __percpu annotation to perf_cgroup->info
2013-03-18 9:56 ` [PATCH v2] " Namhyung Kim
@ 2013-03-18 11:13 ` tip-bot for Namhyung Kim
0 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Namhyung Kim @ 2013-03-18 11:13 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, a.p.zijlstra, acme, namhyung.kim,
namhyung, tj, tglx, lizefan
Commit-ID: 86e213e1d901fbeaf6e57d13c5edd925fadddcbe
Gitweb: http://git.kernel.org/tip/86e213e1d901fbeaf6e57d13c5edd925fadddcbe
Author: Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Mon, 18 Mar 2013 18:56:34 +0900
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 18 Mar 2013 11:02:06 +0100
perf/cgroup: Add __percpu annotation to perf_cgroup->info
It's a per-cpu data structure but missed the __percpu annotation.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Link: http://lkml.kernel.org/r/1363600594-11453-1-git-send-email-namhyung@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5976a2a..efb75b3 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -245,7 +245,7 @@ struct perf_cgroup_info {
struct perf_cgroup {
struct cgroup_subsys_state css;
- struct perf_cgroup_info *info;
+ struct perf_cgroup_info __percpu *info;
};
/*
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-18 11:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-18 5:14 [PATCH] perf cgroup: Add __percpu annotation to perf_cgroup->info Namhyung Kim
2013-03-18 9:39 ` Ingo Molnar
2013-03-18 9:56 ` [PATCH v2] " Namhyung Kim
2013-03-18 11:13 ` [tip:perf/core] perf/cgroup: " tip-bot for Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox