[PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[Silviu-Mihai Popescu]

This uses PTR_RET instead of IS_ERR and PTR_ERR in order to increase
readability.

Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
 net/bluetooth/hci_sysfs.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
index 23b4e24..6fb5065 100644
--- a/net/bluetooth/hci_sysfs.c
+++ b/net/bluetooth/hci_sysfs.c
@@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
 	bt_debugfs = debugfs_create_dir("bluetooth", NULL);
 
 	bt_class = class_create(THIS_MODULE, "bluetooth");
-	if (IS_ERR(bt_class))
-		return PTR_ERR(bt_class);
-
-	return 0;
+	return PTR_RET(bt_class)
 }
 
 void bt_sysfs_cleanup(void)
-- 
1.7.9.5

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[David Miller]

From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Date: Tue, 12 Mar 2013 20:13:15 +0200

> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
>  	bt_debugfs = debugfs_create_dir("bluetooth", NULL);
>  
>  	bt_class = class_create(THIS_MODULE, "bluetooth");
> -	if (IS_ERR(bt_class))
> -		return PTR_ERR(bt_class);
> -
> -	return 0;
> +	return PTR_RET(bt_class)

Don't bother submitting patches you aren't even going to try
to compile.

I'm rejecting all of your current submissions.  Resubmit them
when you feel like typing 'make' from time to time.

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[Silviu Popescu]

On Wed, Mar 13, 2013 at 11:31 AM, David Miller <davem@davemloft.net> wrote:
> From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
> Date: Tue, 12 Mar 2013 20:13:15 +0200
>
>> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
>>       bt_debugfs = debugfs_create_dir("bluetooth", NULL);
>>
>>       bt_class = class_create(THIS_MODULE, "bluetooth");
>> -     if (IS_ERR(bt_class))
>> -             return PTR_ERR(bt_class);
>> -
>> -     return 0;
>> +     return PTR_RET(bt_class)
>
> Don't bother submitting patches you aren't even going to try
> to compile.
>
> I'm rejecting all of your current submissions.  Resubmit them
> when you feel like typing 'make' from time to time.
>
>

Sorry for the trouble caused and sorry for the late reply.
That being said, I'd like to understand a bit better what exactly I messed up.
I've just pulled the latest revision of the mainline kernel and made
the changes in this patch.
I've tried with make defconfig (which would be x86_64_defconfig in my
case), followed by
make menuconfig to select the bluetooth options and make allyesconfig.
Both defconfig and allyesconfig compile successfully on my system.
Would you be so kind as to tell me what error you have encountered?
Or perhaps enlighten me as to what I'm still doing wrong. I'd like to
learn from my mistakes.

Thanks,
Silviu Popescu

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[David Miller]

From: Silviu Popescu <silviupopescu1990@gmail.com>
Date: Mon, 18 Mar 2013 20:05:42 +0200

>>> +     return PTR_RET(bt_class)
 ..
> That being said, I'd like to understand a bit better what exactly I messed up.

There's no semicolon at the end of the return statement.

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[Joe Perches]

On Mon, 2013-03-18 at 20:05 +0200, Silviu Popescu wrote:
> On Wed, Mar 13, 2013 at 11:31 AM, David Miller <davem@davemloft.net> wrote:
> > From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
> > Date: Tue, 12 Mar 2013 20:13:15 +0200
> >
> >> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
> >>       bt_debugfs = debugfs_create_dir("bluetooth", NULL);
> >>
> >>       bt_class = class_create(THIS_MODULE, "bluetooth");
> >> -     if (IS_ERR(bt_class))
> >> -             return PTR_ERR(bt_class);
> >> -
> >> -     return 0;
> >> +     return PTR_RET(bt_class)
> >
> > Don't bother submitting patches you aren't even going to try
> > to compile.
> >
> > I'm rejecting all of your current submissions.  Resubmit them
> > when you feel like typing 'make' from time to time.
> >
> >
> 
> Sorry for the trouble caused and sorry for the late reply.
> That being said, I'd like to understand a bit better what exactly I messed up.
> I've just pulled the latest revision of the mainline kernel and made
> the changes in this patch.
> I've tried with make defconfig (which would be x86_64_defconfig in my
> case), followed by
> make menuconfig to select the bluetooth options and make allyesconfig.
> Both defconfig and allyesconfig compile successfully on my system.
> Would you be so kind as to tell me what error you have encountered?
> Or perhaps enlighten me as to what I'm still doing wrong. I'd like to
> learn from my mistakes.

You do have to ensure that the file you modify
is actually compiled.

Sometimes it's easier to type make path/file.o

In any case, this is missing the statement terminating
semicolon after PTR_RET(bt_class).

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[Silviu Popescu]

On Mon, Mar 18, 2013 at 8:05 PM, Silviu Popescu
<silviupopescu1990@gmail.com> wrote:
> On Wed, Mar 13, 2013 at 11:31 AM, David Miller <davem@davemloft.net> wrote:
>> From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
>> Date: Tue, 12 Mar 2013 20:13:15 +0200
>>
>>> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
>>>       bt_debugfs = debugfs_create_dir("bluetooth", NULL);
>>>
>>>       bt_class = class_create(THIS_MODULE, "bluetooth");
>>> -     if (IS_ERR(bt_class))
>>> -             return PTR_ERR(bt_class);
>>> -
>>> -     return 0;
>>> +     return PTR_RET(bt_class)
>>
>> Don't bother submitting patches you aren't even going to try
>> to compile.
>>
>> I'm rejecting all of your current submissions.  Resubmit them
>> when you feel like typing 'make' from time to time.
>>
>>
>
> Sorry for the trouble caused and sorry for the late reply.
> That being said, I'd like to understand a bit better what exactly I messed up.
> I've just pulled the latest revision of the mainline kernel and made
> the changes in this patch.
> I've tried with make defconfig (which would be x86_64_defconfig in my
> case), followed by
> make menuconfig to select the bluetooth options and make allyesconfig.
> Both defconfig and allyesconfig compile successfully on my system.
> Would you be so kind as to tell me what error you have encountered?
> Or perhaps enlighten me as to what I'm still doing wrong. I'd like to
> learn from my mistakes.

Please ignore this gratuitous stupidity.
The right patch was applied locally, the wrong one sent to the list.
I'll resubmit the proper one.

-- 
Silviu Popescu

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

[Gustavo Padovan]

[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]

Hi Silviu,

* Silviu Popescu <silviupopescu1990@gmail.com> [2013-03-18 20:13:50 +0200]:

> On Mon, Mar 18, 2013 at 8:05 PM, Silviu Popescu
> <silviupopescu1990@gmail.com> wrote:
> > On Wed, Mar 13, 2013 at 11:31 AM, David Miller <davem@davemloft.net> wrote:
> >> From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
> >> Date: Tue, 12 Mar 2013 20:13:15 +0200
> >>
> >>> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
> >>>       bt_debugfs = debugfs_create_dir("bluetooth", NULL);
> >>>
> >>>       bt_class = class_create(THIS_MODULE, "bluetooth");
> >>> -     if (IS_ERR(bt_class))
> >>> -             return PTR_ERR(bt_class);
> >>> -
> >>> -     return 0;
> >>> +     return PTR_RET(bt_class)
> >>
> >> Don't bother submitting patches you aren't even going to try
> >> to compile.
> >>
> >> I'm rejecting all of your current submissions.  Resubmit them
> >> when you feel like typing 'make' from time to time.
> >>
> >>
> >
> > Sorry for the trouble caused and sorry for the late reply.
> > That being said, I'd like to understand a bit better what exactly I messed up.
> > I've just pulled the latest revision of the mainline kernel and made
> > the changes in this patch.
> > I've tried with make defconfig (which would be x86_64_defconfig in my
> > case), followed by
> > make menuconfig to select the bluetooth options and make allyesconfig.
> > Both defconfig and allyesconfig compile successfully on my system.
> > Would you be so kind as to tell me what error you have encountered?
> > Or perhaps enlighten me as to what I'm still doing wrong. I'd like to
> > learn from my mistakes.
> 
> Please ignore this gratuitous stupidity.
> The right patch was applied locally, the wrong one sent to the list.
> I'll resubmit the proper one.

Someone already sent me a similar patch, so this is already fixed in
bluetooth-next. No need to resubmit this one.

	Gustavo

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]