From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Julius Werner <jwerner@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Lan Tianyu <tianyu.lan@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
Sameer Nanda <snanda@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>,
Luigi Semenzato <semenzato@chromium.org>
Subject: Re: [PATCH] usb: Make USB persist default configurable
Date: Mon, 18 Mar 2013 16:09:22 -0700 [thread overview]
Message-ID: <20130318230922.GA23175@kroah.com> (raw)
In-Reply-To: <1363215451-26111-1-git-send-email-jwerner@chromium.org>
On Wed, Mar 13, 2013 at 03:57:31PM -0700, Julius Werner wrote:
> Commit 9214d1d8 set the USB persist flag as a default for all devices.
> This might be desirable for some distributions, but it certainly has its
> trade-offs... most importantly, it can significantly increase system
> resume time, because the kernel blocks on resuming (and sometimes
> resetting) USB devices before it unfreezes userspace.
>
> This patch introduces a new config option CONFIG_USB_DEFAULT_PERSIST,
> which allows distributions to make this decision on their own without
> the need to carry a custom patch or revert the kernel's setting in
> userspace.
Why can't you just revert this in userspace? Isn't that easier than
doing a kernel patch and providing an option that we need to now
maintain for pretty much forever?
thanks,
greg k-h
next prev parent reply other threads:[~2013-03-18 23:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:57 [PATCH] usb: Make USB persist default configurable Julius Werner
2013-03-18 23:09 ` Greg Kroah-Hartman [this message]
2013-03-19 0:02 ` Julius Werner
2013-03-19 0:06 ` Greg Kroah-Hartman
2013-03-19 1:04 ` Julius Werner
2013-03-19 14:56 ` Alan Stern
2013-03-19 15:06 ` Vincent Palatin
2013-03-19 15:42 ` Alan Stern
2013-03-19 17:29 ` Julius Werner
2013-03-20 14:49 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318230922.GA23175@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=semenzato@chromium.org \
--cc=snanda@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=tianyu.lan@intel.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox