From: Greg KH <gregkh@linuxfoundation.org>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, joe@perches.com,
shangw@linux.vnet.ibm.com, linuxram@us.ibm.com
Subject: Re: [PATCH 0/2] Some cleanup in driver core
Date: Mon, 18 Mar 2013 17:17:08 -0700 [thread overview]
Message-ID: <20130319001708.GB13502@kroah.com> (raw)
In-Reply-To: <1362622966-20003-1-git-send-email-weiyang@linux.vnet.ibm.com>
On Thu, Mar 07, 2013 at 10:22:44AM +0800, Wei Yang wrote:
> These two patches do some cleanup in the driver core.
No they do not.
I understand the need to fix code, but please, do so if it is broken.
These patches don't help, and in fact, they hurt things.
Next time, if you wish to send me patches like this, please get someone
else at IBM, who is experienced, to ack them, before sending them on to
me.
greg k-h
next prev parent reply other threads:[~2013-03-19 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 2:22 [PATCH 0/2] Some cleanup in driver core Wei Yang
2013-03-07 2:22 ` [PATCH 1/2] driver core: remove device_add_attrs() in drivers/base/bus.c Wei Yang
2013-03-19 0:18 ` Greg KH
2013-03-19 2:08 ` Wei Yang
2013-03-07 2:22 ` [PATCH 2/2] driver-core: remove the duplicate assignment of kobj->parent in device_add Wei Yang
2013-03-07 11:33 ` Bjørn Mork
[not found] ` <20130307135032.GA6100@richard.(null)>
2013-03-07 14:49 ` Bjørn Mork
2013-03-19 0:17 ` Greg KH [this message]
2013-03-19 2:11 ` [PATCH 0/2] Some cleanup in driver core Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319001708.GB13502@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=shangw@linux.vnet.ibm.com \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox