From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933134Ab3CSFuX (ORCPT ); Tue, 19 Mar 2013 01:50:23 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:45028 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933051Ab3CSFuW (ORCPT ); Tue, 19 Mar 2013 01:50:22 -0400 X-AuditID: 9c930197-b7cc2ae000000eb7-d1-5147fc9dc3d4 Date: Tue, 19 Mar 2013 14:50:42 +0900 From: Joonsoo Kim To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yinghai Lu , Johannes Weiner , Jiang Liu Subject: Re: [PATCH 2/3] mm, nobootmem: clean-up of free_low_memory_core_early() Message-ID: <20130319055042.GD8858@lge.com> References: <1363670161-9214-1-git-send-email-iamjoonsoo.kim@lge.com> <1363670161-9214-2-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363670161-9214-2-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2013 at 02:16:00PM +0900, Joonsoo Kim wrote: > Remove unused argument and make function static, > because there is no user outside of nobootmem.c > > Signed-off-by: Joonsoo Kim > > diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h > index cdc3bab..5f0b0e1 100644 > --- a/include/linux/bootmem.h > +++ b/include/linux/bootmem.h > @@ -44,7 +44,6 @@ extern unsigned long init_bootmem_node(pg_data_t *pgdat, > unsigned long endpfn); > extern unsigned long init_bootmem(unsigned long addr, unsigned long memend); > > -extern unsigned long free_low_memory_core_early(int nodeid); > extern unsigned long free_all_bootmem_node(pg_data_t *pgdat); > extern unsigned long free_all_bootmem(void); > > diff --git a/mm/nobootmem.c b/mm/nobootmem.c > index 4711e91..589c673 100644 > --- a/mm/nobootmem.c > +++ b/mm/nobootmem.c > @@ -120,7 +120,7 @@ static unsigned long __init __free_memory_core(phys_addr_t start, > return end_pfn - start_pfn; > } > > -unsigned long __init free_low_memory_core_early(int nodeid) > +static unsigned long __init free_low_memory_core_early() > { > unsigned long count = 0; > phys_addr_t start, end, size; > @@ -170,7 +170,7 @@ unsigned long __init free_all_bootmem(void) > * because in some case like Node0 doesn't have RAM installed > * low ram will be on Node1 > */ > - return free_low_memory_core_early(MAX_NUMNODES); > + return free_low_memory_core_early(); > } > > /** > -- > 1.7.9.5 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org Sorry, this patch makes build warning. Below is fixed version. -------------------->&------------------------ >>From 05f4a768dd5c514113916908f4710f8863704ed9 Mon Sep 17 00:00:00 2001 From: Joonsoo Kim Date: Mon, 18 Mar 2013 14:17:57 +0900 Subject: [PATCH] mm, nobootmem: clean-up of free_low_memory_core_early() Remove unused argument and make function static, because there is no user outside of nobootmem.c Signed-off-by: Joonsoo Kim diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h index cdc3bab..5f0b0e1 100644 --- a/include/linux/bootmem.h +++ b/include/linux/bootmem.h @@ -44,7 +44,6 @@ extern unsigned long init_bootmem_node(pg_data_t *pgdat, unsigned long endpfn); extern unsigned long init_bootmem(unsigned long addr, unsigned long memend); -extern unsigned long free_low_memory_core_early(int nodeid); extern unsigned long free_all_bootmem_node(pg_data_t *pgdat); extern unsigned long free_all_bootmem(void); diff --git a/mm/nobootmem.c b/mm/nobootmem.c index 4711e91..9c38698 100644 --- a/mm/nobootmem.c +++ b/mm/nobootmem.c @@ -120,7 +120,7 @@ static unsigned long __init __free_memory_core(phys_addr_t start, return end_pfn - start_pfn; } -unsigned long __init free_low_memory_core_early(int nodeid) +static unsigned long __init free_low_memory_core_early(void) { unsigned long count = 0; phys_addr_t start, end, size; @@ -170,7 +170,7 @@ unsigned long __init free_all_bootmem(void) * because in some case like Node0 doesn't have RAM installed * low ram will be on Node1 */ - return free_low_memory_core_early(MAX_NUMNODES); + return free_low_memory_core_early(); } /** -- 1.7.9.5