From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755518Ab3CUFHZ (ORCPT ); Thu, 21 Mar 2013 01:07:25 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:41360 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753646Ab3CUFHX (ORCPT ); Thu, 21 Mar 2013 01:07:23 -0400 Date: Wed, 20 Mar 2013 22:07:18 -0700 From: Tejun Heo To: Dave Chinner Cc: Jan Kara , axboe@kernel.dk, laijs@cn.fujitsu.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org, jmoyer@redhat.com Subject: Re: [PATCH 3/4] writeback: replace custom worker pool implementation with unbound workqueue Message-ID: <20130321050718.GA8012@mtj.dyndns.org> References: <1362692649-25570-1-git-send-email-tj@kernel.org> <1362692649-25570-4-git-send-email-tj@kernel.org> <20130312150510.GF13152@quack.suse.cz> <20130318223244.GA11188@quack.suse.cz> <20130318223526.GH3042@htj.dyndns.org> <20130319154600.GC5222@quack.suse.cz> <20130321015721.GL17758@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130321015721.GL17758@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Dave. On Thu, Mar 21, 2013 at 12:57:21PM +1100, Dave Chinner wrote: > When you have a system that has 50+ active filesystems (pretty > common in the distributed storage environments were every disk has > it's own filesystem), knowing which filesystem(s) are getting stuck > in writeback from the sysrq-w or hangcheck output is pretty damn > important.... Hmm... I guess, then, what we can do is adding a worker description which is printed out with task dump. ie. A work function can call work_set_desc(fmt, arg....). It won't be expensive and can be implemented relatively easily. Does that sound good enough? Thanks. -- tejun