public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: maxin.john@enea.com, s.hauer@pengutronix.de,
	linux-kernel@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch
Date: Thu, 21 Mar 2013 13:54:09 +0530	[thread overview]
Message-ID: <20130321082409.GI10326@intel.com> (raw)
In-Reply-To: <1363132417-15273-1-git-send-email-festevam@gmail.com>

On Tue, Mar 12, 2013 at 08:53:37PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
> the following section mismatch happens:
> 
> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
> The function ipu_remove() references a function in an exit section.
> Often the function ipu_idmac_exit() has valid usage outside the exit section
> and the fix is to remove the __exit annotation of ipu_idmac_exit.
> 
> Remove the '__exit' annotation from ipu_idmac_exit in order to fix it. 
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied Thanks

--
~Vinod
> ---
>  drivers/dma/ipu/ipu_idmac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index d6d5d7e..d39c2cd 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)
>  	return dma_async_device_register(&idmac->dma);
>  }
>  
> -static void __exit ipu_idmac_exit(struct ipu *ipu)
> +static void ipu_idmac_exit(struct ipu *ipu)
>  {
>  	int i;
>  	struct idmac *idmac = &ipu->idmac;
> -- 
> 1.7.9.5
> 

      parent reply	other threads:[~2013-03-21  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 23:53 [PATCH] dma: ipu: ipu_idmac: Fix section mismatch Fabio Estevam
2013-03-14  0:39 ` Maxin B. John
2013-03-20  5:17   ` Fabio Estevam
2013-03-21  8:24 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130321082409.GI10326@intel.com \
    --to=vinod.koul@intel.com \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxin.john@enea.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox