request line field in the generic slave config structure

request line field in the generic slave config structure

[Shevchenko, Andriy]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 844 bytes --]

Hello!

It seems the one (as I think good) question was left unanswered:
http://www.spinics.net/lists/arm-kernel/msg186120.html

What is your opinions, comments?

-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: request line field in the generic slave config structure

[Arnd Bergmann]

On Monday 18 March 2013, Shevchenko, Andriy wrote:
> Hello!
> 
> It seems the one (as I think good) question was left unanswered:
> http://www.spinics.net/lists/arm-kernel/msg186120.html
> 
> What is your opinions, comments?

I'm not sure I understand what the question was. Is this about
whether we should remove the "slave_id" field in the slave
configuration?

Those sort of duplicate the request line information that comes
from the platform in a data structure that should be filled by
the device driver without platform specific knowledge.

I believe that is currently used by shmobile, and we won't be able
to kill that before that platform has been converted to use
dma_request_slave_channel.

	Arnd

Re: request line field in the generic slave config structure

[Arnd Bergmann]

On Monday 18 March 2013, Shevchenko, Andriy wrote:
> Hello!
> 
> It seems the one (as I think good) question was left unanswered:
> http://www.spinics.net/lists/arm-kernel/msg186120.html
> 
> What is your opinions, comments?

I'm not sure I understand what the question was. Is this about
whether we should remove the "slave_id" field in the slave
configuration?

Those sort of duplicate the request line information that comes
from the platform in a data structure that should be filled by
the device driver without platform specific knowledge.

I believe that is currently used by shmobile, and we won't be able
to kill that before that platform has been converted to use
dma_request_slave_channel.

	Arnd

Re: request line field in the generic slave config structure

[Vinod Koul]

On Mon, Mar 18, 2013 at 01:30:29PM +0000, Arnd Bergmann wrote:
> On Monday 18 March 2013, Shevchenko, Andriy wrote:
> > Hello!
> > 
> > It seems the one (as I think good) question was left unanswered:
> > http://www.spinics.net/lists/arm-kernel/msg186120.html
> > 
> > What is your opinions, comments?
> 
> I'm not sure I understand what the question was. Is this about
> whether we should remove the "slave_id" field in the slave
> configuration?
Ditto :)

The slave_id memeber in dma_slave_config should be used for this

> 
> Those sort of duplicate the request line information that comes
> from the platform in a data structure that should be filled by
> the device driver without platform specific knowledge.
> 
> I believe that is currently used by shmobile, and we won't be able
> to kill that before that platform has been converted to use
> dma_request_slave_channel.
> 
> 	Arnd