public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: H Peter Anvin <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	penguin-kernel@I-love.SAKURA.ne.jp,
	linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH] x86/microcode_intel_early.c: Get 32-bit physical address by __pa_nodebug()
Date: Thu, 21 Mar 2013 11:40:18 +0100	[thread overview]
Message-ID: <20130321104018.GA18484@gmail.com> (raw)
In-Reply-To: <1363705484-27645-1-git-send-email-fenghua.yu@intel.com>


* Fenghua Yu <fenghua.yu@intel.com> wrote:

> +	initrd_start_p = (unsigned long *)__pa_nodebug(&initrd_start);
> +	initrd_start_addr = (unsigned long)__pa_nodebug(*initrd_start_p);

We should probably use __pa_early() for that - aliased to __pa_nodebug(). 
That would self-document the purpose.

Thanks,

	Ingo

  parent reply	other threads:[~2013-03-21 10:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 15:04 [PATCH] x86/microcode_intel_early.c: Get 32-bit physical address by __pa_nodebug() Fenghua Yu
2013-03-19 23:15 ` Yinghai Lu
2013-03-19 23:21   ` H. Peter Anvin
2013-03-19 23:36   ` Yu, Fenghua
2013-03-19 23:48     ` Yinghai Lu
2013-03-20  0:03       ` H. Peter Anvin
2013-03-20  2:06 ` Tetsuo Handa
2013-03-20  3:11 ` [tip:x86/urgent] x86-32, microcode_intel_early: Fix crash with CONFIG_DEBUG_VIRTUAL tip-bot for Fenghua Yu
2013-03-21 10:40 ` Ingo Molnar [this message]
2013-03-21 14:30   ` [PATCH] x86/microcode_intel_early.c: Get 32-bit physical address by __pa_nodebug() H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130321104018.GA18484@gmail.com \
    --to=mingo@kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox