* [PATCH tip/core/urgent] Fix for hlist_entry_safe() regression
@ 2013-03-14 20:53 Paul E. McKenney
2013-03-21 14:22 ` [GIT PULL " Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2013-03-14 20:53 UTC (permalink / raw)
To: mingo
Cc: linux-kernel, davej, sasha.levin, akpm, torvalds, caiqian,
eric.dumazet, lizefan
Hello, Ingo
This series contains a single commit that fixes a regression in
hlist_entry_safe(). This macro references its argument twice, which
can cause NULL-pointer errors. This commit applies a gcc statement
expression, creating a temporary variable to avoid the double reference.
This has been posted to LKML at https://lkml.org/lkml/2013/3/9/75.
Kudos to CAI Qian, whose testing uncovered this, to Eric Dumazet, who
spotted root cause, and to Li Zefan, who tested this commit.
This commit is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent
Thanx, Paul
----------------------------------------------------------------
Paul E. McKenney (1):
list: Fix double fetch of pointer in hlist_entry_safe()
include/linux/list.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [GIT PULL tip/core/urgent] Fix for hlist_entry_safe() regression
2013-03-14 20:53 [PATCH tip/core/urgent] Fix for hlist_entry_safe() regression Paul E. McKenney
@ 2013-03-21 14:22 ` Paul E. McKenney
2013-03-21 14:42 ` Linus Torvalds
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2013-03-21 14:22 UTC (permalink / raw)
To: mingo
Cc: linux-kernel, davej, sasha.levin, akpm, torvalds, caiqian,
eric.dumazet, lizefan
[Reposting with corrected subject line.]
Hello, Ingo,
This series contains a single commit that fixes a regression in
hlist_entry_safe(). This macro references its argument twice, which
can cause NULL-pointer errors. This commit applies a gcc statement
expression, creating a temporary variable to avoid the double reference.
This has been posted to LKML at https://lkml.org/lkml/2013/3/9/75.
Kudos to CAI Qian, whose testing uncovered this, to Eric Dumazet, who
spotted root cause, and to Li Zefan, who tested this commit.
This commit is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent
Thanx, Paul
----------------------------------------------------------------
Paul E. McKenney (1):
list: Fix double fetch of pointer in hlist_entry_safe()
include/linux/list.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL tip/core/urgent] Fix for hlist_entry_safe() regression
2013-03-21 14:22 ` [GIT PULL " Paul E. McKenney
@ 2013-03-21 14:42 ` Linus Torvalds
2013-03-21 15:05 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2013-03-21 14:42 UTC (permalink / raw)
To: Paul McKenney
Cc: Ingo Molnar, Linux Kernel Mailing List, Dave Jones, Sasha Levin,
Andrew Morton, CAI Qian, Eric Dumazet, lizefan
On Thu, Mar 21, 2013 at 7:22 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> [Reposting with corrected subject line.]
>
> Hello, Ingo,
>
> This series contains a single commit that fixes a regression in
> hlist_entry_safe(). ..
You do realize that I already merged this a week ago directly? (Merge
commit f4846e52c517)
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL tip/core/urgent] Fix for hlist_entry_safe() regression
2013-03-21 14:42 ` Linus Torvalds
@ 2013-03-21 15:05 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2013-03-21 15:05 UTC (permalink / raw)
To: Linus Torvalds
Cc: Ingo Molnar, Linux Kernel Mailing List, Dave Jones, Sasha Levin,
Andrew Morton, CAI Qian, Eric Dumazet, lizefan
On Thu, Mar 21, 2013 at 07:42:03AM -0700, Linus Torvalds wrote:
> On Thu, Mar 21, 2013 at 7:22 AM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > [Reposting with corrected subject line.]
> >
> > Hello, Ingo,
> >
> > This series contains a single commit that fixes a regression in
> > hlist_entry_safe(). ..
>
> You do realize that I already merged this a week ago directly? (Merge
> commit f4846e52c517)
I do now! I must confess that I didn't think to check mainline.
Please accept my apologies for the noise.
Thanx, Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-21 15:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-14 20:53 [PATCH tip/core/urgent] Fix for hlist_entry_safe() regression Paul E. McKenney
2013-03-21 14:22 ` [GIT PULL " Paul E. McKenney
2013-03-21 14:42 ` Linus Torvalds
2013-03-21 15:05 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox