From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, Dave Chinner <david@fromorbit.com>,
axboe@kernel.dk, laijs@cn.fujitsu.com, fengguang.wu@intel.com,
linux-kernel@vger.kernel.org, jmoyer@redhat.com
Subject: Re: [PATCH 3/4] writeback: replace custom worker pool implementation with unbound workqueue
Date: Thu, 21 Mar 2013 11:37:11 -0700 [thread overview]
Message-ID: <20130321183711.GD20500@htj.dyndns.org> (raw)
In-Reply-To: <20130321130819.GA8721@infradead.org>
Hey, Christoph.
On Thu, Mar 21, 2013 at 09:08:19AM -0400, Christoph Hellwig wrote:
> > > Hmm... I guess, then, what we can do is adding a worker description
> > > which is printed out with task dump. ie. A work function can call
> > > work_set_desc(fmt, arg....). It won't be expensive and can be
> > > implemented relatively easily. Does that sound good enough?
> > Yeah, that sounds good! Thanks!
>
> How about automatically doing this based on the workqueue name?
We already have that information and just need to print it. The thing
is some users including writeback want further identifying information
inside the workqueue. The same workqueue would be serving all
writeback work items but it would be nice to be able to distinguish
which specific device was being serviced, so we need more information
than the associated workqueue.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-03-21 18:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 21:44 [PATCHSET] writeback: convert writeback to unbound workqueue Tejun Heo
2013-03-07 21:44 ` [PATCH 1/4] implement current_is_workqueue_rescuer() Tejun Heo
2013-03-13 0:42 ` Tejun Heo
2013-03-07 21:44 ` [PATCH 2/4] writeback: remove unused bdi_pending_list Tejun Heo
2013-03-12 12:02 ` Jan Kara
2013-03-07 21:44 ` [PATCH 3/4] writeback: replace custom worker pool implementation with unbound workqueue Tejun Heo
2013-03-12 15:05 ` Jan Kara
2013-03-18 22:32 ` Jan Kara
2013-03-18 22:35 ` Tejun Heo
2013-03-19 15:46 ` Jan Kara
2013-03-19 17:28 ` Tejun Heo
2013-03-21 1:57 ` Dave Chinner
2013-03-21 5:07 ` Tejun Heo
2013-03-21 11:32 ` Jan Kara
2013-03-21 13:08 ` Christoph Hellwig
2013-03-21 18:37 ` Tejun Heo [this message]
2013-03-07 21:44 ` [PATCH 4/4] writeback: expose the bdi_wq workqueue Tejun Heo
2013-03-12 15:06 ` [PATCHSET] writeback: convert writeback to unbound workqueue Jens Axboe
2013-03-12 17:10 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321183711.GD20500@htj.dyndns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).