From: Thierry Reding <thierry.reding@avionic-design.de>
To: Philip Avinash <avinashphilip@ti.com>
Cc: nsekhar@ti.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
prakash.pm@ti.com
Subject: Re: [PATCH v2] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices
Date: Fri, 22 Mar 2013 11:45:08 +0100 [thread overview]
Message-ID: <20130322104508.GA9804@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1363761564-14814-1-git-send-email-avinashphilip@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On Wed, Mar 20, 2013 at 12:09:24PM +0530, Philip Avinash wrote:
> Add EHRPWM and ECAP support build support for DAVINCI_DA8XX platforms.
>
> Also, since DAVINCI platforms doesn't support TI-PWM-Subsystem module,
> remove the select option for CONFIG_PWM_TIPWMSS.
>
> Also, update CONFIG_PWM_TIPWMSS compiler directive appropriately in
> pwm-tipwmss.h to fix the below compiler error upon removal of
> CONFIG_PWM_TIPWMSS for DAVINCI platforms.
>
> drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_probe':
> drivers/pwm/pwm-tiecap.c:263:4: error: 'PWMSS_ECAPCLK_EN' undeclared
> (first use in this function)
> drivers/pwm/pwm-tiecap.c:263:4: note: each undeclared identifier
> is reported only once for each function it appears in
> drivers/pwm/pwm-tiecap.c:264:17: error: 'PWMSS_ECAPCLK_EN_ACK'
> undeclared (first use in this function)
> drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_remove':
> drivers/pwm/pwm-tiecap.c:291:49: error: 'PWMSS_ECAPCLK_STOP_REQ'
> undeclared (first use in this function)
> make[2]: *** [drivers/pwm/pwm-tiecap.o] Error 1
> make[1]: *** [drivers/pwm] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> ---
> Changes Since v1:
> - Change the Kconfig dependency to ARCH_DAVINCI_DA8XX from
> ARCH_DAVINCI_DA850.
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-03-22 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 6:39 [PATCH v2] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices Philip Avinash
2013-03-22 10:45 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322104508.GA9804@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=avinashphilip@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=prakash.pm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox