From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933927Ab3CVQRc (ORCPT ); Fri, 22 Mar 2013 12:17:32 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:47198 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933838Ab3CVQR3 (ORCPT ); Fri, 22 Mar 2013 12:17:29 -0400 Date: Fri, 22 Mar 2013 16:16:44 +0000 From: Matthew Garrett To: Michal Marek Cc: Alex Williamson , Takashi Iwai , Bjorn Helgaas , Oliver Neukum , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pciehp: Add pciehp_surprise module option Message-ID: <20130322161644.GA28760@srcf.ucam.org> References: <1363802953.24132.513.camel@bling.home> <514C8388.3050200@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <514C8388.3050200@suse.cz> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2013 at 05:15:04PM +0100, Michal Marek wrote: > Alex, Matthew, would it work for you to have this debug / band-aid > option _and_ have a list of either machines' dmi strings that have this > problem, or devices' PCI IDs (*), and enable the surprise event handling > for such machines / devices automatically? The option would be still > useful for debugging, to be able to easily find out if given machine has > this problem and needs to be added to the quirk list. That's be preferable, but if there's anything we've learned about dmi strings it's that they usually mean we're doing something wrong. Does this work with Windows without any quirking? Is there a machine-specific driver for the PCIe chipset? -- Matthew Garrett | mjg59@srcf.ucam.org