* [PATCH 1/1] clk: Fix incorrect return type in clk.c
@ 2013-03-13 9:47 Sachin Kamat
2013-03-13 17:09 ` Pankaj Jangra
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-03-13 9:47 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, mturquette, sachin.kamat
Return type of function clk_propagate_rate_change is a pointer.
But 0 was being returned. Change it to NULL.
Silences the following warning:
drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/clk/clk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ed87b24..467b31f 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -974,7 +974,7 @@ static struct clk *clk_propagate_rate_change(struct clk *clk, unsigned long even
int ret = NOTIFY_DONE;
if (clk->rate == clk->new_rate)
- return 0;
+ return NULL;
if (clk->notifier_count) {
ret = __clk_notify(clk, event, clk->rate, clk->new_rate);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] clk: Fix incorrect return type in clk.c
2013-03-13 9:47 [PATCH 1/1] clk: Fix incorrect return type in clk.c Sachin Kamat
@ 2013-03-13 17:09 ` Pankaj Jangra
2013-03-22 19:19 ` Mike Turquette
0 siblings, 1 reply; 3+ messages in thread
From: Pankaj Jangra @ 2013-03-13 17:09 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-arm-kernel, mturquette, linux-kernel
Hi.
On Wed, Mar 13, 2013 at 3:17 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Return type of function clk_propagate_rate_change is a pointer.
> But 0 was being returned. Change it to NULL.
> Silences the following warning:
> drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/clk/clk.c | 2 +-
Looks good to me.
Reviewed-by: Pankaj Jangra <jangra.pankaj9@gmail.com>
Regards,
Pankaj Jangra
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] clk: Fix incorrect return type in clk.c
2013-03-13 17:09 ` Pankaj Jangra
@ 2013-03-22 19:19 ` Mike Turquette
0 siblings, 0 replies; 3+ messages in thread
From: Mike Turquette @ 2013-03-22 19:19 UTC (permalink / raw)
To: Pankaj Jangra, Sachin Kamat; +Cc: linux-arm-kernel, linux-kernel
Quoting Pankaj Jangra (2013-03-13 10:09:18)
> Hi.
>
> On Wed, Mar 13, 2013 at 3:17 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > Return type of function clk_propagate_rate_change is a pointer.
> > But 0 was being returned. Change it to NULL.
> > Silences the following warning:
> > drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > drivers/clk/clk.c | 2 +-
>
> Looks good to me.
> Reviewed-by: Pankaj Jangra <jangra.pankaj9@gmail.com>
>
Thanks for the fix. Taken into clk-next.
Regards,
Mike
> Regards,
> Pankaj Jangra
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-22 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-13 9:47 [PATCH 1/1] clk: Fix incorrect return type in clk.c Sachin Kamat
2013-03-13 17:09 ` Pankaj Jangra
2013-03-22 19:19 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).