public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Caj Larsson <caj@omnicloud.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Zombie stuck in zap_pid_ns_processes()
Date: Sun, 24 Mar 2013 14:20:47 +0100	[thread overview]
Message-ID: <20130324132047.GA13419@redhat.com> (raw)
In-Reply-To: <87txo1kqj5.fsf@xmission.com>

On 03/24, Eric W. Biederman wrote:
>
> --- a/kernel/pid_namespace.c
> +++ b/kernel/pid_namespace.c
> @@ -181,6 +181,7 @@ void zap_pid_ns_processes(struct pid_namespace *pid_ns)
>  	int nr;
>  	int rc;
>  	struct task_struct *task, *me = current;
> +	int init_pids = task_pid_vnr(me) == 1 ? 1 : 2;
                        ^^^^^^^^^^^^^^^^^^^^^

Ah, mt-init.

perhaps thread_group_leader(me) would be more clean/simple,
but I won't insist of course.

Oleg.


  reply	other threads:[~2013-03-24 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20  8:43 Zombie stuck in zap_pid_ns_processes() Caj Larsson
2013-03-24 11:04 ` Eric W. Biederman
2013-03-24 13:20   ` Oleg Nesterov [this message]
2013-03-26 10:29     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130324132047.GA13419@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=caj@omnicloud.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox