From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Subject: Re: BUG: using smp_processor_id() in preemptible [00000000] code: asm/8267
Date: Sun, 24 Mar 2013 16:59:24 +0100 [thread overview]
Message-ID: <20130324155924.GB4866@pd.tnic> (raw)
In-Reply-To: <20130324115556.GA4866@pd.tnic>
On Sun, Mar 24, 2013 at 12:55:56PM +0100, Borislav Petkov wrote:
> Hi,
>
> so I was tracing a small .c program like so:
>
> $ ./perf record ~/test/asm
>
> and here's what got spewed in dmesg. Kernel is plain -rc4. Any pending
> fixes in tip I should try?
>
> [ 3700.194208] BUG: using smp_processor_id() in preemptible [00000000] code: asm/8333
> [ 3700.194226] caller is perf_event_task_ctx+0x55/0x140
Ok, here's the call stack I was able to reconstruct:
perf_event_exit_task()
|->perf_event_exit_task_context()
|-> perf_event_task()
|-> perf_event_task_event()
|-> perf_event_task_ctx()
|-> perf_event_task_match()
|-> event_filter_match()
|-> smp_processor_id() -> debug_smp_processor_id()
Now, my primitive thinking would presume that since we're on the
exit_task path, we're still on the same cpu so the check triggers
wrongly but I don't know for sure. Also, is there any possibility for
this code to be moved somewhere else, i.e. to another cpu, so that the
check actually is correct?
Hmm.
Adding Stephane who added that check in
fa66f07aa1f0950e1dc78b7ab39728b3f8aa77a1.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-03-24 15:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 11:55 BUG: using smp_processor_id() in preemptible [00000000] code: asm/8267 Borislav Petkov
2013-03-24 15:59 ` Borislav Petkov [this message]
2013-03-26 18:34 ` Borislav Petkov
2013-03-27 6:02 ` Namhyung Kim
2013-03-27 9:49 ` Borislav Petkov
2013-03-27 10:42 ` Jiri Olsa
2013-03-27 14:09 ` Peter Zijlstra
2013-03-27 16:31 ` Borislav Petkov
2013-04-30 15:27 ` [RFCv2] " Jiri Olsa
2013-03-27 13:15 ` Joerg Roedel
2013-03-27 14:17 ` Peter Zijlstra
2013-03-27 14:37 ` Paul E. McKenney
2013-03-27 16:34 ` Joerg Roedel
2013-03-27 16:38 ` Borislav Petkov
2013-03-27 18:04 ` Paul E. McKenney
2013-03-27 19:07 ` Borislav Petkov
2013-03-27 19:20 ` Borislav Petkov
2013-03-27 19:22 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130324155924.GB4866@pd.tnic \
--to=bp@alien8.de \
--cc=acme@infradead.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox