From: Oleg Nesterov <oleg@redhat.com>
To: Anton Arapov <anton@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Josh Stone <jistone@redhat.com>, Frank Eigler <fche@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
adrian.m.negreanu@intel.com, Torsten.Polle@gmx.de
Subject: [PATCH 3/5] uprobes: Kill the unnecesary filp != NULL check in __copy_insn()
Date: Sun, 24 Mar 2013 19:21:18 +0100 [thread overview]
Message-ID: <20130324182118.GA13315@redhat.com> (raw)
In-Reply-To: <20130324182040.GA13078@redhat.com>
__copy_insn(filp) can only be called after valid_vma() returns T,
vma->vm_file passed as "filp" can not be NULL.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/events/uprobes.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 0a759c6..e5d479f 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -478,9 +478,6 @@ __copy_insn(struct address_space *mapping, struct file *filp, char *insn,
{
struct page *page;
- if (!filp)
- return -EINVAL;
-
if (!mapping->a_ops->readpage)
return -EIO;
/*
--
1.5.5.1
next prev parent reply other threads:[~2013-03-24 18:23 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 13:08 [PATCH 0/7] uretprobes: return probes implementation Anton Arapov
2013-03-22 13:08 ` [PATCH 1/7] uretprobes: preparation patch Anton Arapov
2013-03-23 17:42 ` Oleg Nesterov
2013-03-22 13:08 ` [PATCH 2/7] uretprobes: extract fill_page() and trampoline implementation Anton Arapov
2013-03-24 14:41 ` Oleg Nesterov
2013-03-24 18:20 ` [PATCH 0/5] kmap cleanups for uretprobes (Was: extract fill_page() and trampoline implementation) Oleg Nesterov
2013-03-24 18:21 ` [PATCH 1/5] uprobes: Turn copy_opcode() into copy_from_page() Oleg Nesterov
2013-03-25 10:30 ` Anton Arapov
2013-03-26 11:59 ` Srikar Dronamraju
2013-03-24 18:21 ` [PATCH 2/5] uprobes: Change __copy_insn() to use copy_from_page() Oleg Nesterov
2013-03-25 10:31 ` Anton Arapov
2013-03-26 12:00 ` Srikar Dronamraju
2013-03-24 18:21 ` Oleg Nesterov [this message]
2013-03-25 10:31 ` [PATCH 3/5] uprobes: Kill the unnecesary filp != NULL check in __copy_insn() Anton Arapov
2013-03-26 12:00 ` Srikar Dronamraju
2013-03-24 18:21 ` [PATCH 4/5] uprobes: Introduce copy_to_page() Oleg Nesterov
2013-03-25 10:31 ` Anton Arapov
2013-03-26 12:02 ` Srikar Dronamraju
2013-03-24 18:21 ` [PATCH 5/5] uprobes: Change write_opcode() to use copy_*page() Oleg Nesterov
2013-03-25 10:31 ` Anton Arapov
2013-03-26 11:59 ` Srikar Dronamraju
2013-03-25 10:30 ` [PATCH 0/5] kmap cleanups for uretprobes (Was: extract fill_page() and trampoline implementation) Anton Arapov
2013-03-25 11:58 ` [PATCH 2/7] uretprobes: extract fill_page() and trampoline implementation Oleg Nesterov
2013-03-22 13:09 ` [PATCH 3/7] uretprobes/x86: hijack return address Anton Arapov
2013-03-24 14:59 ` Oleg Nesterov
2013-03-22 13:09 ` [PATCH 4/7] uretprobes: return probe entry, prepare_uretprobe() Anton Arapov
2013-03-22 15:02 ` Oleg Nesterov
2013-03-26 12:26 ` Anton Arapov
2013-03-26 14:34 ` Oleg Nesterov
2013-03-23 17:46 ` Oleg Nesterov
2013-03-24 15:26 ` Oleg Nesterov
2013-03-25 15:51 ` Anton Arapov
2013-03-26 8:45 ` Anton Arapov
2013-03-26 8:50 ` Anton Arapov
2013-03-22 13:09 ` [PATCH 5/7] uretprobes: return probe exit, invoke handlers Anton Arapov
2013-03-24 16:28 ` Oleg Nesterov
2013-03-25 12:31 ` Oleg Nesterov
2013-03-25 15:49 ` Anton Arapov
2013-03-25 16:38 ` Oleg Nesterov
2013-03-26 8:36 ` Anton Arapov
2013-03-22 13:09 ` [PATCH 6/7] uretprobes: limit the depth of return probe nestedness Anton Arapov
2013-03-24 16:54 ` Oleg Nesterov
2013-03-22 13:09 ` [PATCH 7/7] uretprobes: implemented, thus remove -ENOSYS Anton Arapov
2013-03-22 13:13 ` Anton Arapov
2013-03-22 13:09 ` [PATCH 7/7] uretprobes: remove -ENOSYS as return probes implemented Anton Arapov
2013-03-22 15:10 ` [PATCH 0/7] uretprobes: return probes implementation Oleg Nesterov
2013-03-22 21:40 ` Josh Stone
2013-03-23 6:43 ` Anton Arapov
2013-03-23 18:04 ` Oleg Nesterov
2013-03-23 17:56 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130324182118.GA13315@redhat.com \
--to=oleg@redhat.com \
--cc=Torsten.Polle@gmx.de \
--cc=adrian.m.negreanu@intel.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=fche@redhat.com \
--cc=jistone@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).