From: Jens Axboe <axboe@kernel.dk>
To: Tanya Brokhman <tlinder@codeaurora.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Alex.Lemberg@sandisk.com,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] block: Add support for reinsert a dispatched req
Date: Mon, 25 Mar 2013 06:34:10 -0600 [thread overview]
Message-ID: <20130325123410.GG22327@kernel.dk> (raw)
In-Reply-To: <1364202150-8776-1-git-send-email-tlinder@codeaurora.org>
On Mon, Mar 25 2013, Tanya Brokhman wrote:
> From: Tatyana Brokhman <tlinder@codeaurora.org>
>
> Add support for reinserting a dispatched request back to the
> scheduler's internal data structures.
> This capability is used by the device driver when it chooses to
> interrupt the current request transmission and execute another (more
> urgent) pending request. For example: interrupting long write in order
> to handle pending read. The device driver re-inserts the
> remaining write request back to the scheduler, to be rescheduled
> for transmission later on.
>
> Add API for verifying whether the current scheduler
> supports reinserting requests mechanism. If reinsert mechanism isn't
> supported by the scheduler, this code path will never be activated.
This is practically the exact same operation as a requeue. So why this
duplication? I also don't quite understand why an IO scheduler would
have to opt-in for this, seems like a pretty basic operation.
--
Jens Axboe
next prev parent reply other threads:[~2013-03-25 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 9:01 [PATCH v5 1/3] block: Add support for reinsert a dispatched req Tanya Brokhman
2013-03-25 12:34 ` Jens Axboe [this message]
2013-03-27 19:09 ` tlinder
2013-03-28 18:49 ` Jens Axboe
2013-03-29 19:07 ` Tanya Brokhman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325123410.GG22327@kernel.dk \
--to=axboe@kernel.dk \
--cc=Alex.Lemberg@sandisk.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox