From: Arnd Bergmann <arnd@arndb.de>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Ley Foon Tan <lftan@altera.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property
Date: Mon, 25 Mar 2013 12:47:58 +0000 [thread overview]
Message-ID: <201303251247.58823.arnd@arndb.de> (raw)
In-Reply-To: <20130325122851.GB20052@xps8300>
On Monday 25 March 2013, Heikki Krogerus wrote:
> On Mon, Mar 25, 2013 at 11:40:31AM +0000, Arnd Bergmann wrote:
> > On Monday 25 March 2013, Heikki Krogerus wrote:
> > > This will add support for hardware flow control. It is
> > > limited to be used only with 8250 driver.
> > >
> > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
> > Does this imply that we can use hardware flow control only when this
> > flag is set in the device tree? I assumed that working flow control
> > would be the default. Is it not?
>
> OK, the commit message is wrong. Is the patch otherwise OK?
I still find the text in the binding and the name of the property confusing,
because it seems to imply that you have no hardware flow control without this.
I think what you mean here is really "automatic flow control" rather than
"hardware flow control".
Arnd
next prev parent reply other threads:[~2013-03-25 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:34 [PATCH 0/3] serial: of_serial: new properties Heikki Krogerus
2013-03-25 11:34 ` [PATCH 1/3] serial: 8250: Allow probe drivers to ignore tx_loadsz Heikki Krogerus
2013-03-25 11:34 ` [PATCH 2/3] serial: of_serial: Handle fifo-size property Heikki Krogerus
2013-03-25 11:38 ` Arnd Bergmann
2013-03-25 11:34 ` [PATCH 3/3] serial: of_serial: Handle hw-flow-control property Heikki Krogerus
2013-03-25 11:40 ` Arnd Bergmann
2013-03-25 12:28 ` Heikki Krogerus
2013-03-25 12:47 ` Arnd Bergmann [this message]
2013-03-25 12:57 ` Heikki Krogerus
2013-03-25 13:04 ` Arnd Bergmann
2013-03-25 13:17 ` Heikki Krogerus
2013-03-25 13:51 ` [PATCHv2 3/3] serial: of_serial: Handle auto-flow-control property Heikki Krogerus
2013-03-25 13:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303251247.58823.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox