Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property

Arnd Bergmann
2013-03-25T13:04:52Z

On Monday 25 March 2013, Heikki Krogerus wrote:
> On Mon, Mar 25, 2013 at 12:47:58PM +0000, Arnd Bergmann wrote:
> > On Monday 25 March 2013, Heikki Krogerus wrote:
> > > On Mon, Mar 25, 2013 at 11:40:31AM +0000, Arnd Bergmann wrote:
> > > > On Monday 25 March 2013, Heikki Krogerus wrote:
> > > > > This will add support for hardware flow control. It is
> > > > > limited to be used only with 8250 driver.
> > > > >
> > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > >
> > > > Does this imply that we can use hardware flow control only when this
> > > > flag is set in the device tree? I assumed that working flow control
> > > > would be the default. Is it not?
> > >
> > > OK, the commit message is wrong. Is the patch otherwise OK?
> >
> > I still find the text in the binding and the name of the property confusing,
> > because it seems to imply that you have no hardware flow control without this.
> > I think what you mean here is really "automatic flow control" rather than
> > "hardware flow control".
>
> Ah, I understand. I'll change the property name to auto-flow-control.
>

Ok, sounds good. I would also suggest rewording the description in the
binding so that the driver is allowed to detect the presence of the automatic
flow control capability even if the property is not set, because that's
what the driver does.

Arnd