From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Metcalf <cmetcalf@tilera.com>,
Christoph Lameter <cl@linux.com>,
Geoff Levand <geoff@infradead.org>,
Gilad Ben Yossef <gilad@benyossef.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Kevin Hilman <khilman@linaro.org>,
Li Zhong <zhong@linux.vnet.ibm.com>,
Namhyung Kim <namhyung.kim@lge.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] nohz: Full dynticks base interface
Date: Mon, 25 Mar 2013 10:02:57 -0700 [thread overview]
Message-ID: <20130325170257.GA24554@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAFTL4hx4FLaRR6i9ap9UrCZY4ikhVtLfUqWSsjTpsO3dvShUjQ@mail.gmail.com>
On Sun, Mar 24, 2013 at 03:46:40PM +0100, Frederic Weisbecker wrote:
> 2013/3/24 Ingo Molnar <mingo@kernel.org>:
> >
> > * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >
> >> Hi Ingo,
> >>
> >> This settles the initial ground to start a special full dynticks tree in -tip
> >> that we can iterate incrementally to accelerate the development.
> >> It is based on tip:sched/core.
> >>
> >> I tried to rearrange a bit the naming. We are probably not yet done with
> >> that but I guess we can fix it along with the rest.
> >>
> >> Please pull from:
> >>
> >> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> >> full-dynticks-for-mingo
> >>
> >> Changes on these commits since they were part of 3.9-rc1-nohz1:
> >>
> >> * Force a timekeeping CPU over the full dynticks range
> >> * Rename CONFIG_NO_HZ_FULL to CONFIG_NO_HZ_EXTENDED
> >> * Following *_nohz_extended_* APIs renames
> >> * Handle CPU hotplug for timekeeping
> >> * Rename full_nohz= kernel parameter to nohz_extended=
> >
> > Note that boot parameters suck for pretty much any purpose but quirks -
> > please also add a (default off!) Kconfig option to easily enable
> > nohz_extended for all CPUs.
> >
> > That way I will be able to test it automatically via randconfig and such.
>
> Sure, I'm adding such an option.
Hmmm... This would be an option to make all but one CPU an adaptive-ticks
CPU, right? If so, this leads to the question of whether I should add a
matching no-CBs Kconfig option. My guess is "no", because the existing
CONFIG_RCU_NOCB_CPU_ALL should work just fine -- there would be a CPU that
was not an adaptive-ticks CPU, but does have its RCU callbacks offloaded.
Or am I missing something here?
Thanx, Paul
> > My next question/request after that would be: could we make sure that
> > enabling this option does not break any applications or kernel
> > functionality, ASAP? Once that is offered, it becomes pushable to v3.10 I
> > think.
>
> So that's already the case. I'm careful that, as we iterate, the
> changes aren't supposed to break something in the middle. the final
> code that eventually shuts the tick down should be the last one in the
> series: once we know it is safe to do so.
>
> >
> > Meanwhile I have pulled your tree into tip:sched/nohz to stage and test
> > it, in the hope that it becomes mergable quickly! :-)
>
> Thanks! :)
>
next prev parent reply other threads:[~2013-03-25 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 15:24 [GIT PULL] nohz: Full dynticks base interface Frederic Weisbecker
2013-03-21 15:24 ` [PATCH 1/3] nohz: Basic full dynticks interface Frederic Weisbecker
2013-03-21 15:24 ` [PATCH 2/3] nohz: Assign timekeeping duty to a CPU outside the full dynticks range Frederic Weisbecker
2013-03-21 15:24 ` [PATCH 3/3] nohz: Wake up full dynticks CPUs when a timer gets enqueued Frederic Weisbecker
2013-03-24 8:17 ` [GIT PULL] nohz: Full dynticks base interface Ingo Molnar
2013-03-24 14:46 ` Frederic Weisbecker
2013-03-25 17:02 ` Paul E. McKenney [this message]
2013-03-25 17:12 ` Frederic Weisbecker
2013-03-25 17:18 ` Paul E. McKenney
2013-03-26 23:48 ` Frederic Weisbecker
2013-03-27 1:23 ` Paul E. McKenney
2013-03-26 8:15 ` Ingo Molnar
2013-03-26 12:39 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325170257.GA24554@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=geoff@infradead.org \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox