From: Greg KH <gregkh@linuxfoundation.org>
To: "Nick Østergaard" <oe.nick@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: prism2usb.c: fix printk(KERN_ERR... to pr_err(...
Date: Mon, 25 Mar 2013 12:17:32 -0700 [thread overview]
Message-ID: <20130325191732.GA22609@kroah.com> (raw)
In-Reply-To: <1364238148-22329-1-git-send-email-oe.nick@gmail.com>
On Mon, Mar 25, 2013 at 08:02:28PM +0100, Nick Østergaard wrote:
> Fixed checkpatch.pl warning, changing fix printk(KERN_ERR... to
> pr_err(...
>
> Signed-off-by: Nick Østergaard <oe.nick@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2usb.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
> index b1aed1f..0f2706a 100644
> --- a/drivers/staging/wlan-ng/prism2usb.c
> +++ b/drivers/staging/wlan-ng/prism2usb.c
> @@ -113,14 +113,14 @@ static int prism2sta_probe_usb(struct usb_interface *interface,
> dev = interface_to_usbdev(interface);
> wlandev = create_wlan();
> if (wlandev == NULL) {
> - printk(KERN_ERR "%s: Memory allocation failure.\n", dev_info);
> + pr_err("%s: Memory allocation failure.\n", dev_info);
Please use dev_err() instead, as you do have a valid struct device in
which to use.
thanks,
greg k-h
next prev parent reply other threads:[~2013-03-25 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 19:02 [PATCH] staging: wlan-ng: prism2usb.c: fix printk(KERN_ERR... to pr_err( Nick Østergaard
2013-03-25 19:17 ` Greg KH [this message]
2013-03-26 13:17 ` [PATCH] staging: wlan-ng: prism2usb.c: fix printk(KERN_ERR... to dev_err(dev, Nick Østergaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325191732.GA22609@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe.nick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox