From: Andrew Morton <akpm@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Alexandru Gheorghiu" <gheorghiuandru@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] drivers: virtio: Use PTR_RET function
Date: Mon, 25 Mar 2013 22:01:50 -0700 [thread overview]
Message-ID: <20130325220150.af9795a7.akpm@linux-foundation.org> (raw)
In-Reply-To: <87fvzidenm.fsf@rustcorp.com.au>
On Tue, 26 Mar 2013 13:57:09 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
> Alexandru Gheorghiu <gheorghiuandru@gmail.com> writes:
>
> > Used PTR_RET function instead of IS_ERR and PTR_ERR.
> > Patch found using coccinelle.
>
> WTF is PTR_RET? PTR_RET doesn't return anything. Why is it called
> that? It doesn't even make sense.
>
> ZERO_OR_PTR_ERR() maybe.
>
> But what problem are we solving? Insufficient churn in the tree? Code
> being too readable? This isn't some hard-to-get right corner case, or a
> missed optimization.
>
> Andrew, what am I missing here?
It seemed like a good idea at the time. Merged it two years ago and
have since been keenly awaiting an opportunity to use it.
It seems that people _have_ been using it, but mainly netfilter people
and we know they're all crazy ;)
next prev parent reply other threads:[~2013-03-26 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 13:25 [PATCH] drivers: virtio: Use PTR_RET function Alexandru Gheorghiu
2013-03-26 3:27 ` Rusty Russell
2013-03-26 5:01 ` Andrew Morton [this message]
[not found] ` <CADca43+r4kPBv-=kqo5VZ4+E2-OD1Y6ipkPXzxmFwrt2x1Z7Vw@mail.gmail.com>
2013-03-26 10:23 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325220150.af9795a7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gheorghiuandru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=u.kleine-koenig@pengutronix.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox